From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Christopher Larson <clarson@kergoth.com>
Cc: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH v5 4/4] bluez5: don't exclude from world builds
Date: Mon, 27 Apr 2015 16:27:16 +0100 [thread overview]
Message-ID: <1430148436.13022.124.camel@linuxfoundation.org> (raw)
In-Reply-To: <1430147691.13022.122.camel@linuxfoundation.org>
On Mon, 2015-04-27 at 16:14 +0100, Richard Purdie wrote:
> On Mon, 2015-04-27 at 07:17 -0700, Christopher Larson wrote:
> > 8262012a90273a4726ebaaf5c4da61262542e69d in bitbake added the initial
> > 'world' implementation, which didn't do such a removal, but did
> > explicitly skip virtual/*, and it looks
> > like aff3227b5e4a3dee9bceb120aac11f4bf3ac6409 implemented the first
> > naive handling of it, beyond the virtual/ prefix, from a quick perusal
> > of bitbake history. It skipped the non-preferred selections of every
> > multiple provider.
>
> Interestingly, that code does survive in buildWorldTargetList() in
> cooker.py.
>
> Clearly when EXCLUDE_FROM_WORLD was added to bluez it wasn't working as
> intended for some reason. Could do with investigation...
Of course its obvious, bluez has no virtual/* provider and yet in a
world build you don't want both built, you want the distro config to
take effect so exclusion is manually specified. At a quick glance that
code is still doing the right thing.
Cheers,
Richard
next prev parent reply other threads:[~2015-04-27 15:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-23 14:38 [PATCH v5 0/4] Switch to BlueZ 5.x as default Bluetooth stack Cristian Iorga
2015-04-23 14:38 ` [PATCH v5 1/4] bluez4: add proper systemd support Cristian Iorga
2015-04-23 14:38 ` [PATCH v5 2/4] bluez: remove bluez4 recipes Cristian Iorga
2015-04-23 14:38 ` [PATCH v5 3/4] bitbake.conf: backfill bluez5 feature Cristian Iorga
2015-04-23 14:38 ` [PATCH v5 4/4] bluez5: don't exclude from world builds Cristian Iorga
2015-04-26 21:57 ` Richard Purdie
2015-04-27 1:17 ` Christopher Larson
2015-04-27 7:13 ` Richard Purdie
2015-04-27 14:17 ` Christopher Larson
2015-04-27 15:14 ` Richard Purdie
2015-04-27 15:27 ` Richard Purdie [this message]
2015-04-23 14:48 ` [PATCH v5 0/4] Switch to BlueZ 5.x as default Bluetooth stack Iorga, Cristian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1430148436.13022.124.camel@linuxfoundation.org \
--to=richard.purdie@linuxfoundation.org \
--cc=clarson@kergoth.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox