Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Ed Bartosh <ed.bartosh@linux.intel.com>
To: openembedded-core@lists.openembedded.org
Subject: [PATCH v.4] kernel.bbclass: Fix race condition
Date: Wed,  6 May 2015 17:03:24 +0300	[thread overview]
Message-ID: <1430921004-21983-1-git-send-email-ed.bartosh@linux.intel.com> (raw)
In-Reply-To: <1430856401.8074.13.camel@linuxfoundation.org>

Race condition between do_compile_kernelmodules and do_shared_workdir
tasks occurs when do_compile_kernelmodules changes files in
include/generated/* while do_shared_workdir tries to copy them to
shared working directory.

Fixed race by moving do_shared_workdir after do_compile_kernelmodules.

[YOCTO #7321]

Signed-off-by: Ed Bartosh <ed.bartosh@linux.intel.com>
---
 meta/classes/kernel.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
index 125ed88..9207ae4 100644
--- a/meta/classes/kernel.bbclass
+++ b/meta/classes/kernel.bbclass
@@ -234,7 +234,7 @@ kernel_do_install() {
 }
 do_install[prefuncs] += "package_get_auto_pr"
 
-addtask shared_workdir after do_compile before do_install
+addtask shared_workdir after do_compile_kernelmodules before do_install
 
 emit_depmod_pkgdata() {
 	# Stash data for depmod
-- 
2.1.4



  parent reply	other threads:[~2015-05-06 14:03 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-14 16:56 [PATCH] kernel.bbclass: Fix race condition Ed Bartosh
2015-05-01 14:28 ` Richard Purdie
2015-05-01 14:31   ` Bruce Ashfield
2015-05-04 14:11   ` Ed Bartosh
2015-05-04 14:33     ` Bruce Ashfield
2015-05-05 20:06     ` Richard Purdie
2015-05-06 10:26       ` Ed Bartosh
2015-05-06 14:03       ` Ed Bartosh [this message]
2015-05-06 14:12         ` [PATCH v.4] " Bruce Ashfield
2015-05-06 14:27         ` Richard Purdie
2015-05-06 20:28           ` [PATCH v.5] " Ed Bartosh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1430921004-21983-1-git-send-email-ed.bartosh@linux.intel.com \
    --to=ed.bartosh@linux.intel.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox