From: Paul Eggleton <paul.eggleton@linux.intel.com>
To: Martin Jansa <martin.jansa@gmail.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [RFC][PATCH 1/2] packagedata: show error when there are multiple pkgdata directories
Date: Thu, 04 Apr 2013 16:48:08 +0100 [thread overview]
Message-ID: <1433160.8b2eM7nW6I@helios> (raw)
In-Reply-To: <20130404153930.GD1271@jama.dyndns-home.com>
On Thursday 04 April 2013 17:39:30 Martin Jansa wrote:
> On Wed, Apr 03, 2013 at 12:14:33PM +0200, Martin Jansa wrote:
> > * when PACKAGE_ARCH is changed e.g. from MACHINE_ARCH to TUNE_PKGARCH
> >
> > get_subpkgedata_fn is still reading old MACHINE_ARCH directory instead
> > of newer with TUNE_PKGARCH
> This is too strict in some cases, e.g.:
>
> ERROR: More then one pkgdata dir found for pkg 'opkg-collateral'
> (
> '/OE/shr-core/tmp-eglibc/pkgdata/cortexa8-vfp-neon-oe-linux-gnueabi/runtime/
> opkg-collateral',
> '/OE/shr-core/tmp-eglibc/pkgdata/armv5te-oe-linux-gnueabi/runtime/opkg-coll
> ateral'), returning first
>
> Why do we need to look in all pkgdatadirs? Why not just PACKAGE_ARCH?
So this code may well not be doing the right thing, but PACKAGE_ARCH won't
work either because this is called to get a list of all packages not just one,
and we therefore have no context to know PACKAGE_ARCH.
Cheers,
Paul
--
Paul Eggleton
Intel Open Source Technology Centre
next prev parent reply other threads:[~2013-04-04 16:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-20 19:26 [PATCH/RFC] netbase: inherit allarch Andreas Oberritter
2013-03-20 20:18 ` Martin Jansa
2013-03-20 20:22 ` Martin Jansa
2013-04-03 10:14 ` [RFC][PATCH 1/2] packagedata: show error when there are multiple pkgdata directories Martin Jansa
2013-04-03 10:14 ` [RFC][PATCH 2/2] packagedata: Show error when trying to change PE/PV/PR from runtime/pkgdata Martin Jansa
2013-04-04 15:39 ` [RFC][PATCH 1/2] packagedata: show error when there are multiple pkgdata directories Martin Jansa
2013-04-04 15:48 ` Paul Eggleton [this message]
2013-04-04 15:58 ` Richard Purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1433160.8b2eM7nW6I@helios \
--to=paul.eggleton@linux.intel.com \
--cc=martin.jansa@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox