Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Steffen Sledz <sledz@dresearch-fe.de>
Cc: Paul Eggleton <paul.eggleton@linux.intel.com>,
	openembedded-devel <openembedded-devel@lists.openembedded.org>,
	openembedded-core@lists.openembedded.org
Subject: Re: multiple git repos vs. AUTOREV?
Date: Wed, 17 Jun 2015 09:10:21 +0100	[thread overview]
Message-ID: <1434528621.14710.3.camel@linuxfoundation.org> (raw)
In-Reply-To: <5581216F.7080503@dresearch-fe.de>

On Wed, 2015-06-17 at 09:27 +0200, Steffen Sledz wrote:
> On 16.06.2015 16:20, Paul Eggleton wrote:
> > On Tuesday 16 June 2015 16:12:49 Steffen Sledz wrote:
> >> For development purposes we use this method to build always from the HEAD
> >> revision of a git repository.
> >> ...
> >> Now we like to do the same in one recipe which uses sources from two git
> >> repos.
> >> ...
> > 
> > I believe this should work:
> > 
> > -------------> snip <--------------
> > SRCREV_FORMAT = "foo_bar"
> > SRCREV_foo = "${AUTOREV}"
> > SRCREV_bar = "${AUTOREV}"
> > PV = "gitr${SRCPV}"
> >  
> > SRC_URI = " \
> > 	git://git@bitbucket.org/.../foo.git;protocol=ssh,name=foo \
> >  	git://git@bitbucket.org/.../bar.git;protocol=ssh,name=bar \
> >  "
> > -------------> snap <--------------
> 
> Thanx.
> 
> Now we have a similar but little different problem definition. We like to integrate the code of an own kernel driver into the current linux-boundary recipe. Because the driver is under development we like to use the HEAD revision of this repo. My first try was this bbappend.
> 
> -------------> snip <--------------
> SRCREV_FORMAT_append += "_mydriver"
> SRCREV_mydriver = "${AUTOREV}"
> PV_append = "gitr${SRCPV}"
> 
> SRC_URI_append = " \
> 	git://github.com/.../mydriver.git;protocol=https;destsuffix=git.mydriver;name=mydriver \
> "
> 
> ...
> -------------> snap <--------------
> 
> But this leads to an error.
> 
> ERROR: ExpansionError during parsing /.../meta-fsl-arm-extra/recipes-kernel/linux/linux-boundary_3.10.53.bb: Failure expanding variable pkg_postrm_kernel-devicetree: ExpansionError: Failure expanding variable KERNEL_PRIORITY, expression was ${@int(d.getVar('PV',1).split('-')[0].split('+')[0].split('.')[0]) * 10000 +                        int(d.getVar('PV',1).split('-')[0].split('+')[0].split('.')[1]) * 100 +                        int(d.getVar('PV',1).split('-')[0].split('+')[0].split('.')[-1])} which triggered exception ValueError: invalid literal for int() with base 10: '53gitrAUTOINC'
> 
> Without the PV_append line everything builds well but the resulting package version does not contain a part for the additional repo version. :(
> 
> Any ideas on this one?

What value of PV does the recipe have originally? That code (from
KERNEL_PRIORITY in kernel.bbclass) is meant to be stripping off the base
version and computing values from it:

d.getVar('PV',1).split('-')[0].split('+')[0].split('.')[0]

however if you don't have a "good" base PV value, its likely its getting
confused. If you use a form like:

PV = "x.y.z"
(in the base recipe)
PV_append = "+gitr${SRCPV}"
(in the append)

then the code above should work ok.

Cheers,

Richard



  reply	other threads:[~2015-06-17  8:10 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-16 14:12 multiple git repos vs. AUTOREV? Steffen Sledz
2015-06-16 14:20 ` Paul Eggleton
2015-06-17  7:27   ` Steffen Sledz
2015-06-17  8:10     ` Richard Purdie [this message]
2015-06-17 10:09       ` Steffen Sledz
2015-06-17 10:25         ` Steffen Sledz
2015-06-17 10:31           ` Paul Eggleton
2015-06-16 14:40 ` [oe] " Martin Jansa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1434528621.14710.3.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=openembedded-devel@lists.openembedded.org \
    --cc=paul.eggleton@linux.intel.com \
    --cc=sledz@dresearch-fe.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox