Re: [PATCH] pixbufcache: Ensure that jpeg-native is available for postinst if necessary

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Tue, 2015-06-23 at 16:25 +0100, Mike Crowe wrote:
> On Tuesday 23 June 2015 at 16:12:26 +0100, Phil Blundell wrote:
> > On Sat, 2015-06-13 at 19:44 +0100, Mike Crowe wrote:
> > > diff --git a/meta/classes/pixbufcache.bbclass b/meta/classes/pixbufcache.bbclass
> > > index 9e6ecc8..755a654 100644
> > > --- a/meta/classes/pixbufcache.bbclass
> > > +++ b/meta/classes/pixbufcache.bbclass
> > > @@ -72,6 +72,7 @@ PIXBUFCACHE_SYSROOT_DEPS_class-native = "\
> > >      glib-2.0-native:do_populate_sysroot_setscene libffi-native:do_populate_sysroot_setscene \
> > >      libpng-native:do_populate_sysroot_setscene zlib-native:do_populate_sysroot_setscene \
> > >      harfbuzz-native:do_populate_sysroot_setscene \
> > > +    ${@bb.utils.contains('PACKAGECONFIG', 'jpeg', 'jpeg-native:do_populate_sysroot_setscene', '', d)} \
> > 
> > I'm not sure this is quite right.  PACKAGECONFIG at the point this is
> > expanded will be the PACKAGECONFIG for whatever recipe is currently
> > inheriting pixbufcache.bbclass, whereas I think what you really need
> > here is the PACKAGECONFIG that gdk-pixbuf itself was built with.  Or,
> > er, something.
> 
> The problem I was seeing was with gdk-pixbuf itself so it sounds like I
> need to add the dependency only when '${BPN}' == 'gdk-pixbuf' itself. I'll
> have a go at that.

I'm still not convinced this is the right route to go down. I'd much
rather find a way to improve my other patch with the right abstractions,
or just accept the ugliness in base.bbclass...

Cheers,

Richard