From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Saul Wold <sgw@linux.intel.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH][master&fido] image.bbclass: Disable USE_DEPMOD for the dummy kernel
Date: Tue, 23 Jun 2015 22:53:47 +0100 [thread overview]
Message-ID: <1435096427.11489.102.camel@linuxfoundation.org> (raw)
In-Reply-To: <1435087374-18117-1-git-send-email-sgw@linux.intel.com>
On Tue, 2015-06-23 at 12:22 -0700, Saul Wold wrote:
> The image bbclass will try to find the kernel-abiversion file which is not part
> of the linux-dummy kernel since there is no actual kernel. In this case using
> depmod also does not make sense since there should not be any kernel module built.
>
> [YOCTO #7884]
>
> Signed-off-by: Saul Wold <sgw@linux.intel.com>
> ---
> meta/classes/image.bbclass | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass
> index 01f8b3f..be245e9 100644
> --- a/meta/classes/image.bbclass
> +++ b/meta/classes/image.bbclass
> @@ -66,7 +66,7 @@ PACKAGE_INSTALL_ATTEMPTONLY ?= "${FEATURE_INSTALL_OPTIONAL}"
> EXCLUDE_FROM_WORLD = "1"
>
> USE_DEVFS ?= "1"
> -USE_DEPMOD ?= "1"
> +USE_DEPMOD ?= '${@oe.utils.conditional("PREFERRED_PROVIDER_virtual/kernel", "linux-dummy", "0", "1", d)}'
>
I'm not convinced this is the right way to solve this. How about we
teach the code in rootfs.py not to generate a modules.dep file if there
are no kernel modules to generate dependency information for?
Cheers,
Richard
next prev parent reply other threads:[~2015-06-23 21:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-23 19:22 [PATCH][master&fido] image.bbclass: Disable USE_DEPMOD for the dummy kernel Saul Wold
2015-06-23 21:53 ` Richard Purdie [this message]
2015-06-23 22:44 ` Saul Wold
2015-06-23 22:54 ` Richard Purdie
2015-08-16 8:02 ` Khem Raj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1435096427.11489.102.camel@linuxfoundation.org \
--to=richard.purdie@linuxfoundation.org \
--cc=openembedded-core@lists.openembedded.org \
--cc=sgw@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox