From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dan.rpsys.net (5751f4a1.skybroadband.com [87.81.244.161]) by mail.openembedded.org (Postfix) with ESMTP id 1BB776E5F6 for ; Wed, 8 Jul 2015 11:55:41 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by dan.rpsys.net (8.14.4/8.14.4/Debian-4.1ubuntu1) with ESMTP id t68BsueC001041 for ; Wed, 8 Jul 2015 12:55:40 +0100 Received: from dan.rpsys.net ([127.0.0.1]) by localhost (dan.rpsys.net [127.0.0.1]) (amavisd-new, port 10024) with LMTP id tGSJBSG_gdQr for ; Wed, 8 Jul 2015 12:55:40 +0100 (BST) Received: from [192.168.3.10] ([192.168.3.10]) (authenticated bits=0) by dan.rpsys.net (8.14.4/8.14.4/Debian-4.1ubuntu1) with ESMTP id t68BtSXu001087 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=NOT) for ; Wed, 8 Jul 2015 12:55:39 +0100 Message-ID: <1436356528.27597.208.camel@linuxfoundation.org> From: Richard Purdie To: openembedded-core Date: Wed, 08 Jul 2015 12:55:28 +0100 X-Mailer: Evolution 3.12.10-0ubuntu1~14.10.1 Mime-Version: 1.0 Subject: [PATCH] oeqa/bbtests: Fix to ensure DL_DIR is set X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Jul 2015 11:55:42 -0000 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit write_config overwrites the config rather than appends to it, so ensure we write both variables in one go. Signed-off-by: Richard Purdie diff --git a/meta/lib/oeqa/selftest/bbtests.py b/meta/lib/oeqa/selftest/bbtests.py index ffe0ea5..7df6b2f 100644 --- a/meta/lib/oeqa/selftest/bbtests.py +++ b/meta/lib/oeqa/selftest/bbtests.py @@ -98,8 +98,9 @@ class BitbakeTests(oeSelfTest): def test_invalid_recipe_src_uri(self): data = 'SRC_URI = "file://invalid"' self.write_recipeinc('man', data) - self.write_config("DL_DIR = \"${TOPDIR}/download-selftest\"") - self.write_config("SSTATE_DIR = \"${TOPDIR}/download-selftest\"") + self.write_config("""DL_DIR = \"${TOPDIR}/download-selftest\" +SSTATE_DIR = \"${TOPDIR}/download-selftest\" +""") bitbake('-ccleanall man') result = bitbake('-c fetch man', ignore_status=True) bitbake('-ccleanall man') @@ -110,8 +111,9 @@ class BitbakeTests(oeSelfTest): @testcase(171) def test_rename_downloaded_file(self): - self.write_config("DL_DIR = \"${TOPDIR}/download-selftest\"") - self.write_config("SSTATE_DIR = \"${TOPDIR}/download-selftest\"") + self.write_config("""DL_DIR = \"${TOPDIR}/download-selftest\" +SSTATE_DIR = \"${TOPDIR}/download-selftest\" +""") data = 'SRC_URI_append = ";downloadfilename=test-aspell.tar.gz"' self.write_recipeinc('aspell', data) bitbake('-ccleanall aspell') @@ -174,8 +176,9 @@ class BitbakeTests(oeSelfTest): @testcase(1035) def test_continue(self): - self.write_config("DL_DIR = \"${TOPDIR}/download-selftest\"") - self.write_config("SSTATE_DIR = \"${TOPDIR}/download-selftest\"") + self.write_config("""DL_DIR = \"${TOPDIR}/download-selftest\" +SSTATE_DIR = \"${TOPDIR}/download-selftest\" +""") self.write_recipeinc('man',"\ndo_fail_task () {\nexit 1 \n}\n\naddtask do_fail_task before do_fetch\n" ) runCmd('bitbake -c cleanall man xcursor-transparent-theme') result = runCmd('bitbake man xcursor-transparent-theme -k', ignore_status=True)