Re: [PATCH 2/9] file: 5.23 -> 5.24

Robert Yang
2015-07-29T05:54:13Z

On 07/28/2015 09:48 PM, Martin Jansa wrote:
> On Tue, Jul 28, 2015 at 02:08:20PM +0100, Burton, Ross wrote:
>> On 28 July 2015 at 03:12, Robert Yang <liezhi.yang@windriver.com> wrote:
>>
>>> * Use git repo rather than tarball since the original SRC_URI is not
>>> stable, it is not reachable sometimes.
>>>
>>
>> Personally speaking I see this as a recipe for a release of file which just
>> happens to use git to fetch the tarball (and presumably that hash is the
>> 5.24 tag). In situations like this I prefer to see the recipe called
>> file_5.24.bb as there's no point having a giant PV including git SHAs when
>> it's just the release.
>
> until someone sets SRCREV_pn-file = "${AUTOREV}" somewhere and git SHAs
> in PV suddenly gets very useful.
>
> Personally speaking I prefer recipes with git SCM in SRC_URI named
> <foo>_git.bb and PV set to "A.B.C+gitr${SRCPV}".

Thanks Ross and Martin, as Ross suggested, when the release is just 5.24,
not 5.24+some patches in the repo, I prefer name it as file_5.24.bb,
so the PV would be 5.24 which is more clear, I will update the patch.

// Robert

>