Re: [PATCH] python3: Fix nativesdk build

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Tue, 2015-08-04 at 09:08 -0600, Gary Thomas wrote:
> On 2015-08-04 08:56, Richard Purdie wrote:
> > On Tue, 2015-08-04 at 08:52 -0600, Gary Thomas wrote:
> >> The nativesdk package is built without Py_DEBUG which causes some
> >> compile errors.  This patch fixes those errors allowing the nativesdk
> >> package to build.
> >>
> >> Signed-off-by: Gary Thomas <gary@mlbassoc.com>
> >> ---
> >>   .../python/python3/fix-nativesdk-build.patch       | 28 ++++++++++++++++++++++
> >>   meta/recipes-devtools/python/python3_3.4.3.bb      |  1 +
> >>   2 files changed, 29 insertions(+)
> >>   create mode 100644 meta/recipes-devtools/python/python3/fix-nativesdk-build.patch
> >>
> >> diff --git a/meta/recipes-devtools/python/python3/fix-nativesdk-build.patch b/meta/recipes-devtools/python/python3/fix-nativesdk-build.patch
> >
> > No description of the patch or Upstream-Status. I'm surprised python
> > would have this issue. Do they not recommend building in this
> > configuration or not support/test it?
> 
> I'm not sure - obviously it's not done often (as it breaks badly)
> 
> Maybe it would be cleaner just to let Py_DEBUG be set for the nativesdk
> build but I couldn't see how/why this is not set in this case.

This is what really worries me. I think we likely should be setting this
and the question is therefore why isn't it set?

Cheers,

Richard