From: Benjamin Esquivel <benjamin.esquivel@linux.intel.com>
To: openembedded-core@lists.openembedded.org
Cc: paul.eggleton@linux.intel.com
Subject: [PATCH v2] bb.utils.movefile: specify dest file name
Date: Fri, 21 Aug 2015 10:05:46 +0000 [thread overview]
Message-ID: <1440151546-22283-1-git-send-email-benjamin.esquivel@linux.intel.com> (raw)
In-Reply-To: <1440079198-31036-1-git-send-email-benjamin.esquivel@linux.intel.com>
When moving a file via the python os.rename function it is required
to specify the path including the file name at the end.
Failure to provide this file name at the destination argument of the
os.rename function raises an OSError exception.
[YOCTO#8180]
Signed-off-by: Benjamin Esquivel <benjamin.esquivel@linux.intel.com>
---
bitbake/lib/bb/utils.py | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/bitbake/lib/bb/utils.py b/bitbake/lib/bb/utils.py
index 5b94432..5ed8e01 100644
--- a/bitbake/lib/bb/utils.py
+++ b/bitbake/lib/bb/utils.py
@@ -741,7 +741,11 @@ def movefile(src, dest, newmtime = None, sstat = None):
renamefailed = 1
if sstat[stat.ST_DEV] == dstat[stat.ST_DEV]:
try:
- os.rename(src, dest)
+ # os.rename needs to know the destination path with file name
+ srcfname = os.path.basename(src)
+ destfname = os.path.join(dest, srcfname) if os.path.isdir(dest) \
+ else dest
+ os.rename(src, destfname)
renamefailed = 0
except Exception as e:
if e[0] != errno.EXDEV:
--
2.3.0
next prev parent reply other threads:[~2015-08-21 18:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-20 13:59 [PATCH] utils.movefile: specify dest file name Benjamin Esquivel
2015-08-21 10:05 ` Benjamin Esquivel [this message]
2015-08-27 16:17 ` [PATCH v2] bb.utils.movefile: " Benjamin Esquivel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1440151546-22283-1-git-send-email-benjamin.esquivel@linux.intel.com \
--to=benjamin.esquivel@linux.intel.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=paul.eggleton@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox