From: Benjamin Esquivel <benjamin.esquivel@linux.intel.com>
To: leonardo.sandoval.gonzalez@linux.intel.com,
openembedded-core@lists.openembedded.org,
georgex.l.musat@intel.com
Subject: Re: [PATCH] init-install-efi.sh: Avoid /mnt/mtab creation if already present
Date: Fri, 21 Aug 2015 15:02:33 -0500 [thread overview]
Message-ID: <1440187353.6529.24.camel@linux.intel.com> (raw)
In-Reply-To: <1438614064-10290-1-git-send-email-leonardo.sandoval.gonzalez@linux.intel.com>
Hi Leo, this fix looks good to me, can you mention how did you test
this?
On Mon, 2015-08-03 at 15:01 +0000,
leonardo.sandoval.gonzalez@linux.intel.com wrote:
> From: Leonardo Sandoval <leonardo.sandoval.gonzalez@linux.intel.com>
>
> The base-files recipe installs /mnt/mtab (it is a softlink of
> /proc/mounts),
> so if an image includes the latter, there is no new to created it
> again inside
> the install-efi.sh script, otherwise an error may occur as indicated
> on the
> bug's site.
>
> [YOCTO #7971]
>
> Signed-off-by: Leonardo Sandoval <
> leonardo.sandoval.gonzalez@linux.intel.com>
> ---
> meta/recipes-core/initrdscripts/files/init-install-efi.sh | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/meta/recipes-core/initrdscripts/files/init-install
> -efi.sh b/meta/recipes-core/initrdscripts/files/init-install-efi.sh
> index f339b30..665d04a 100644
> --- a/meta/recipes-core/initrdscripts/files/init-install-efi.sh
> +++ b/meta/recipes-core/initrdscripts/files/init-install-efi.sh
> @@ -109,7 +109,11 @@ rm -f /etc/udev/scripts/mount*
> umount ${device}* 2> /dev/null || /bin/true
>
> mkdir -p /tmp
> -cat /proc/mounts > /etc/mtab
> +
> +# Create /etc/mtab if not present
> +if [ ! -e /etc/mtab ]; then
> + cat /proc/mounts > /etc/mtab
> +fi
>
> disk_size=$(parted ${device} unit mb print | grep Disk | cut -d" "
> -f 3 | sed -e "s/MB//")
>
> --
> 1.8.4.5
>
next prev parent reply other threads:[~2015-08-21 20:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-03 15:01 [PATCH] init-install-efi.sh: Avoid /mnt/mtab creation if already present leonardo.sandoval.gonzalez
2015-08-21 20:02 ` Benjamin Esquivel [this message]
2015-08-25 14:25 ` Leonardo Sandoval
2015-09-02 19:19 ` Leonardo Sandoval
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1440187353.6529.24.camel@linux.intel.com \
--to=benjamin.esquivel@linux.intel.com \
--cc=georgex.l.musat@intel.com \
--cc=leonardo.sandoval.gonzalez@linux.intel.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox