Re: [PATCH] runqemu-internal: Fixes unary operator expected in new TCPSERIAL_PORTNUM

[Benjamin Esquivel <benjamin.esquivel@linux.intel.com>]

On Wed, 2015-08-26 at 09:48 -0500, Aníbal Limón wrote:
> If $TCPSERIAL_PORTNUM is empty string causes an error because
> expands the expresion to,
> 
> $TCPSERIAL_PORTNUM == "" -> == ""
> 
> Signed-off-by: Aníbal Limón <anibal.limon@linux.intel.com>
> ---
>  scripts/runqemu-internal | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/runqemu-internal b/scripts/runqemu-internal
> index b317358..1b1bc9e 100755
> --- a/scripts/runqemu-internal
> +++ b/scripts/runqemu-internal
> @@ -620,7 +620,7 @@ if [ "x$QEMUOPTIONS" = "x" ]; then
>      return 1
>  fi
>  
> -if [ $TCPSERIAL_PORTNUM != "" ]; then
> +if [ "$TCPSERIAL_PORTNUM" != "" ]; then
I believe this would work but if you want to make it bulletproof you'd:
if [ X"$TCPSERIAL_PORTNUM" != X"" ]; then
>      if [ "$MACHINE" = "qemuarm64" ]; then
>          QEMUOPTIONS="$QEMUOPTIONS -device virtio-serial-device 
> -chardev socket,id=virtcon,port=$TCPSERIAL_PORTNUM,host=127.0.0.1 
> -device virtconsole,chardev=virtcon"
>      else
> -- 
> 1.9.1
>