Re: [PATCH V3 0/3] Add UEFI firmware for qemux86*

[Patrick Ohly <patrick.ohly@intel.com>]

On Thu, 2015-08-27 at 14:50 -0500, Leonardo Sandoval wrote:
> On 08/27/2015 08:19 AM, Patrick Ohly wrote:
> > When I use runqemu, it ends up invoking qemu with "-vga vmware". With
> > that, I don't see any output from TianoCore and booting hangs. It boots
> > when disabling graphical output ("serial nographic" as parameter of
> > runqemu) or when explicitly selecting a different graphics
> > ("'qemuparams=-vga std'"). Might be worthwhile adding to the commit
> > message.
> 
> In the 3/3 commit's description, there is a command line with the 
> nographic parameter. I did not test with any other kernel command line.

True, that example works. But it is not clear that the "nographic" is
important. Being explicit about it and adding the graphical case would
be useful.

> > Do you happen to know how non-volatile EFI variables are handled? There
> > are several posts from around 2012 saying that qemu does not support
> > storing nvram persistently (for example, [1]). I've not seen anything
> > more recent directly contradicting that, but there seems to be
> > something, at least in Fedora [2]. That patch mentions that "OVMF [...]
> > works in two
> > modes: 1) Code and UEFI variable store is mixed in one file. ...".
> >
> 
> sorry, I do not know.

I think this will require further work - see my comment on the runqemu
patch.

Do you have time for a forth revision?

-- 
Best Regards, Patrick Ohly

The content of this message is my personal opinion only and although
I am an employee of Intel, the statements I make here in no way
represent Intel's position on the issue, nor am I authorized to speak
on behalf of Intel on this matter.