Re: [PATCH 1/1] busybox: more nails in the coffin

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Fri, 2015-09-04 at 19:18 -0700, Joe Slater wrote:
> Create packagegroup-busybox and modify packagegroup-core-boot
> to conditionally use it.

This says what it goes but not why. I'm also less than keen on the
subject line :/.

> Signed-off-by: Joe Slater <jslater@windriver.com>
> ---
>  .../packagegroups/packagegroup-busybox.bb          |   23 ++++++++++++++++++++
>  .../packagegroups/packagegroup-core-boot.bb        |   17 ++++++++-------
>  2 files changed, 32 insertions(+), 8 deletions(-)
>  create mode 100644 meta/recipes-core/packagegroups/packagegroup-busybox.bb
> 
> diff --git a/meta/recipes-core/packagegroups/packagegroup-busybox.bb b/meta/recipes-core/packagegroups/packagegroup-busybox.bb
> new file mode 100644
> index 0000000..acf0791
> --- /dev/null
> +++ b/meta/recipes-core/packagegroups/packagegroup-busybox.bb
> @@ -0,0 +1,23 @@
> +#
> +# Copyright (C) 2015 Wind River Inc.
> +#
> +
> +SUMMARY = "Busybox related information"
> +DESCRIPTION = "Busybox packages and variables"
> +LICENSE = "MIT"
> +
> +PACKAGE_ARCH = "${MACHINE_ARCH}"
> +
> +inherit packagegroup
> +
> +# Do not ever, ever override LOCAL variables.
> +#

Why?

> +LOCAL_sysvinit = " \
> +                   ${@bb.utils.contains('MACHINE_FEATURES', 'rtc', 'busybox-hwclock', '', d)} \
> +                   "
> +
> +RDEPENDS_${PN} = "\
> +    busybox \
> +    ${@bb.utils.contains("DISTRO_FEATURES", "sysvinit", "${LOCAL_sysvinit}", "", d)} \
> +    "
> +
> diff --git a/meta/recipes-core/packagegroups/packagegroup-core-boot.bb b/meta/recipes-core/packagegroups/packagegroup-core-boot.bb
> index 09f5373..b2d0775 100644
> --- a/meta/recipes-core/packagegroups/packagegroup-core-boot.bb
> +++ b/meta/recipes-core/packagegroups/packagegroup-core-boot.bb
> @@ -17,14 +17,17 @@ inherit packagegroup
>  MACHINE_ESSENTIAL_EXTRA_RDEPENDS ?= ""
>  MACHINE_ESSENTIAL_EXTRA_RRECOMMENDS ?= ""
>  
> -# Distro can override the following VIRTUAL-RUNTIME providers:
> +# These can be overridden in any .conf file.
> +#
>  VIRTUAL-RUNTIME_dev_manager ?= "udev"
> -VIRTUAL-RUNTIME_login_manager ?= "busybox"
> -VIRTUAL-RUNTIME_init_manager ?= "sysvinit"
>  VIRTUAL-RUNTIME_initscripts ?= "initscripts"
>  VIRTUAL-RUNTIME_keymaps ?= "keymaps"
> +VIRTUAL-RUNTIME_busybox ?= "packagegroup-busybox"

What about anyone who actually use these existing VIRTUAL-RUNTIME
variables?

Cheers,

Richard