From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dan.rpsys.net (5751f4a1.skybroadband.com [87.81.244.161]) by mail.openembedded.org (Postfix) with ESMTP id 100AE60053 for ; Wed, 16 Sep 2015 15:26:32 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by dan.rpsys.net (8.14.4/8.14.4/Debian-4.1ubuntu1) with ESMTP id t8GFQVgE028982; Wed, 16 Sep 2015 16:26:31 +0100 Received: from dan.rpsys.net ([127.0.0.1]) by localhost (dan.rpsys.net [127.0.0.1]) (amavisd-new, port 10024) with LMTP id Hjs6StQ6u-0v; Wed, 16 Sep 2015 16:26:31 +0100 (BST) Received: from [192.168.3.10] ([192.168.3.10]) (authenticated bits=0) by dan.rpsys.net (8.14.4/8.14.4/Debian-4.1ubuntu1) with ESMTP id t8GFQIEh028978 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=NOT); Wed, 16 Sep 2015 16:26:29 +0100 Message-ID: <1442417178.26666.117.camel@linuxfoundation.org> From: Richard Purdie To: Robert Yang Date: Wed, 16 Sep 2015 16:26:18 +0100 In-Reply-To: <55F97519.5000600@windriver.com> References: <6f49ee1c3fac0a39d8976d7c74000ad507031516.1442370259.git.liezhi.yang@windriver.com> <1442407090.26666.64.camel@linuxfoundation.org> <55F97519.5000600@windriver.com> X-Mailer: Evolution 3.12.11-0ubuntu3 Mime-Version: 1.0 Cc: openembedded-core@lists.openembedded.org Subject: Re: [PATCH 3/4] insane.bbclass: fix package_qa_check_buildpaths X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Sep 2015 15:26:35 -0000 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit On Wed, 2015-09-16 at 21:56 +0800, Robert Yang wrote: > On 09/16/2015 08:38 PM, Richard Purdie wrote: > > On Tue, 2015-09-15 at 19:28 -0700, Robert Yang wrote: > >> * Ignore elf files because they usually contain build path: > >> - The path of the source file such as .c, these are usually happen > >> when separate B and S since we use absolute path to run configure > >> script, and then VPATH in Makefile will be an absolute path and > >> contains build path, we can use relative path in autotools.bbclass > >> to fix the problem, but we don't have to since they are harmless. > >> - The configure options such as "configure --with-libtool-sysroot" > >> - The compile options such as "gcc --sysroot" > >> These are harmless usually, so ignore elf files. > > > > I'm not sure about this. Yes, elf files have large issues in the debug > > symbols but the main elf files really shouldn't have build paths in > > them. I understand they can creep in through a variety of sources > > including B!=S but we should really be identifying them and fixing them, > > not pretending they don't exist. The whole point of this check > > originally was to get to the bottom of this! > > Thanks, the fix will change a lot to the build behaviour, I'd like to fix > them in 2.1. Agreed, this is 2.1 material at this point. Cheers, Richard