From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: "Reshetova, Elena" <elena.reshetova@intel.com>
Cc: "openembedded-core@lists.openembedded.org"
<openembedded-core@lists.openembedded.org>
Subject: Re: How to put a correct dependency with regards to gcc?
Date: Wed, 16 Sep 2015 17:43:47 +0100 [thread overview]
Message-ID: <1442421827.26666.142.camel@linuxfoundation.org> (raw)
In-Reply-To: <2236FBA76BA1254E88B949DDB74E612B41976CB1@IRSMSX102.ger.corp.intel.com>
On Fri, 2015-09-04 at 17:03 +0000, Reshetova, Elena wrote:
> I have a simple problem but not able to come with simple and elegant
> solution for it, so would be very thankful for the suggestions.
>
> I have a task that is specified to run after do_fetch. The task needs
> the source to be *actually* fetched, since it operates on archives. It
> works well for everything apart gcc.
>
> For example in fido branch, my task run for libgcc will fail, because
> do_fetch task for libgcc actually *does not* not fetch the gcc sources
> (only puts a nice lock file in the download folder).
>
> When I noticed this, I tried to put the dependency on
> gcc-source:do_fetch for my task (because that actually fetches the gcc
> sources) and it works in fido, but in master after changes to gcc
> nothing provides gcc-source and it wants to specify the version, which
> I don’t want to do (ideally I don’t want to put any dependencies to
> gcc, since I don’t really depend on it!). In master a run for
> libgcc-initial fails for the same reasons: gcc tar ball is not there.
>
> Is there a way to make it work correctly?
We could change gcc-shared-work.inc to add:
do_fetch[depends] += "gcc-source-${PV}:do_fetch"
which I think might fix the issues you're seeing. The good news is that
gcc is pretty unique in this regard so you shouldn't see the issue
anywhere else.
I'm also wondering whether we simply should set SRC_URI to be empty
here. The source is fetched, unpacked and patched as part of the
gcc-source recipe. Your code should only really analyse the copy in
gcc-source, its the same source used by all the different gcc variants.
Cheers,
Richard
prev parent reply other threads:[~2015-09-16 16:44 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-04 17:03 How to put a correct dependency with regards to gcc? Reshetova, Elena
2015-09-09 2:45 ` Randy MacLeod
2015-09-09 7:05 ` Patrick Ohly
2015-09-09 16:13 ` Reshetova, Elena
2015-09-09 16:09 ` Reshetova, Elena
2015-09-14 17:55 ` Randy MacLeod
2015-09-14 18:06 ` Reshetova, Elena
2015-09-16 2:37 ` Randy MacLeod
2015-09-16 16:52 ` Richard Purdie
2015-09-22 11:03 ` Reshetova, Elena
2015-09-22 11:09 ` Richard Purdie
2015-09-22 11:13 ` Reshetova, Elena
2015-09-16 16:43 ` Richard Purdie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1442421827.26666.142.camel@linuxfoundation.org \
--to=richard.purdie@linuxfoundation.org \
--cc=elena.reshetova@intel.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox