From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mail.openembedded.org (Postfix) with ESMTP id 8753C60053 for ; Mon, 21 Sep 2015 16:35:12 +0000 (UTC) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga103.jf.intel.com with ESMTP; 21 Sep 2015 09:29:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.17,568,1437462000"; d="scan'208,217";a="649260687" Received: from besquive-mobl2.amr.corp.intel.com ([10.219.17.236]) by orsmga003.jf.intel.com with ESMTP; 21 Sep 2015 09:27:05 -0700 Message-ID: <1442852840.3222.1.camel@linux.intel.com> From: Benjamin Esquivel To: "Istrate, Daniel AlexandruX" , "Burton, Ross" In-Reply-To: <174AD7CFE5F468498ACCFE3FEE0EF1EB142C2921@IRSMSX102.ger.corp.intel.com> References: <6871706.tbebiTIoD4@peggleto-mobl.ger.corp.intel.com> <1442565245-16632-1-git-send-email-benjamin.esquivel@linux.intel.com> <174AD7CFE5F468498ACCFE3FEE0EF1EB142C089D@IRSMSX102.ger.corp.intel.com> <174AD7CFE5F468498ACCFE3FEE0EF1EB142C2921@IRSMSX102.ger.corp.intel.com> Organization: Intel Corporation Date: Mon, 21 Sep 2015 11:27:20 -0500 Mime-Version: 1.0 X-Mailer: Evolution 3.16.5 (3.16.5-1.fc22) Cc: "paul.eggleton@linux.intel.com" , "openembedded-core@lists.openembedded.org" Subject: Re: [PATCH V2] selftest/buildoptions: pexpect not a builtin module X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list Reply-To: benjamin.esquivel@linux.intel.com List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Sep 2015 16:35:18 -0000 Content-Type: multipart/alternative; boundary="=-YmWJvZ2G2tW9xdaMQQe4" --=-YmWJvZ2G2tW9xdaMQQe4 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Great! thanks Daniel. On Mon, 2015-09-21 at 10:49 +0000, Istrate, Daniel AlexandruX wrote: > Hi Ross, > > I sent the patch: http://lists.openembedded.org/pipermail/openembedde > d-core/2015-September/110738.html > > --Daniel > > From: Burton, Ross [mailto:ross.burton@intel.com] > Sent: Monday, September 21, 2015 13:20 > To: Istrate, Daniel AlexandruX > Cc: Benjamin Esquivel; openembedded-core@lists.openembedded.org; > paul.eggleton@linux.intel.com > Subject: Re: [OE-core] [PATCH V2] selftest/buildoptions: pexpect not > a builtin module > > > On 21 September 2015 at 09:37, Istrate, Daniel AlexandruX < > daniel.alexandrux.istrate@intel.com> wrote: > Just want to point out that 'pexpect' is an unused import in > buildoptions.py. Unused imports are also unittest and logging. > Instead of try-catch an import that is not used I think it's best to > get rid of them. > > Totally agreed. Can you send a quick patch? > > Ross --=-YmWJvZ2G2tW9xdaMQQe4 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

Great! thanks Daniel.

On Mon, 2015-09-21 at 10:49 +0000, Istrate, Daniel AlexandruX wrote:

Hi Ross,

I sent the patch: http://lists.openembedded.org/pipermail/openembedded-core/2015-September/110738.html

--Daniel

From: Burton, Ross [mailto:ross.burton@intel.com]
Sent: Monday, September 21, 2015 13:20
To: Istrate, Daniel AlexandruX
Cc: Benjamin Esquivel; openembedded-core@lists.openembedded.org; paul.eggleton@linux.intel.com
Subject: Re: [OE-core] [PATCH V2] selftest/buildoptions: pexpect not a builtin module

On 21 September 2015 at 09:37, Istrate, Daniel AlexandruX <daniel.alexandrux.istrate@intel.com> wrote:

Just want to point out that 'pexpect' is an unused import in buildoptions.py. Unused imports are also unittest and logging.
Instead of try-catch an import that is not used I think it's best to get rid of them.

Totally agreed. Can you send a quick patch?

Ross

--=-YmWJvZ2G2tW9xdaMQQe4--