From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <richard.purdie@linuxfoundation.org>
Received: from dan.rpsys.net (5751f4a1.skybroadband.com [87.81.244.161])
	by mail.openembedded.org (Postfix) with ESMTP id 9ED2176AC4
	for <openembedded-core@lists.openembedded.org>;
	Tue, 29 Sep 2015 22:55:23 +0000 (UTC)
Received: from localhost (localhost [127.0.0.1])
	by dan.rpsys.net (8.14.4/8.14.4/Debian-4.1ubuntu1) with ESMTP id
	t8TMtKm2002153; Tue, 29 Sep 2015 23:55:20 +0100
Received: from dan.rpsys.net ([127.0.0.1])
	by localhost (dan.rpsys.net [127.0.0.1]) (amavisd-new, port 10024)
	with LMTP id GWsQvVLtmO4I; Tue, 29 Sep 2015 23:55:20 +0100 (BST)
Received: from [192.168.3.10] ([192.168.3.10]) (authenticated bits=0)
	by dan.rpsys.net (8.14.4/8.14.4/Debian-4.1ubuntu1) with ESMTP id
	t8TMt60a002149
	(version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=NOT);
	Tue, 29 Sep 2015 23:55:17 +0100
Message-ID: <1443567306.5162.62.camel@linuxfoundation.org>
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Alejandro Hernandez <alejandro.hernandez@linux.intel.com>
Date: Tue, 29 Sep 2015 23:55:06 +0100
In-Reply-To: <64ff08ec839f8d92b942c846bc2975362275aed2.1443548707.git.alejandro.hernandez@linux.intel.com>
References: <cover.1443548707.git.alejandro.hernandez@linux.intel.com>
	<64ff08ec839f8d92b942c846bc2975362275aed2.1443548707.git.alejandro.hernandez@linux.intel.com>
X-Mailer: Evolution 3.12.11-0ubuntu3 
Mime-Version: 1.0
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 1/1] archiver.bbclass: Fix archiver for gcc packages using patched sources
X-BeenThere: openembedded-core@lists.openembedded.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: Patches and discussions about the oe-core layer
	<openembedded-core.lists.openembedded.org>
List-Unsubscribe: <http://lists.openembedded.org/mailman/options/openembedded-core>,
	<mailto:openembedded-core-request@lists.openembedded.org?subject=unsubscribe>
List-Archive: <http://lists.openembedded.org/pipermail/openembedded-core/>
List-Post: <mailto:openembedded-core@lists.openembedded.org>
List-Help: <mailto:openembedded-core-request@lists.openembedded.org?subject=help>
List-Subscribe: <http://lists.openembedded.org/mailman/listinfo/openembedded-core>,
	<mailto:openembedded-core-request@lists.openembedded.org?subject=subscribe>
X-List-Received-Date: Tue, 29 Sep 2015 22:55:25 -0000
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit

On Tue, 2015-09-29 at 17:45 +0000, Alejandro Hernandez wrote:
> gcc packages use a shared source directory, this causes an issue since
> the archiver will try to patch the same source several times (one for
> each gcc package), producing an error, the archiver class used stamp-base
> to check this, nonetheless our gcc packages no longer use stamp-base,
> they use gcc-shared instead, which is what broke this functionality
> this patch adds a check to see whether or not the source should be patched,
> avoiding patching the source when it shouldnt.

Surely the source archiver shouldn't be doing *anything* if SRC_URI is
empty?

We don't need 20 copies of the gcc source code.

Cheers,

Richard