Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Markus Lehtonen <markus.lehtonen@linux.intel.com>
To: Paul Eggleton <paul.eggleton@linux.intel.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH v3 10/10] devtool: modify: make bitbake use local files from srctree
Date: Wed, 30 Sep 2015 12:01:13 +0300	[thread overview]
Message-ID: <1443603673.11206.35.camel@linux.intel.com> (raw)
In-Reply-To: <2936022.hqFWI3dATu@peggleto-mobl.ger.corp.intel.com>

Hi,

On Mon, 2015-09-28 at 14:48 +0100, Paul Eggleton wrote:
> Hi Markus,
> 
> On Thursday 24 September 2015 14:53:07 Markus Lehtonen wrote:
> > This change makes it possible to have local files (non-remote SRC_URI
> > files, i.e. files that are located in the "recipe space") under the
> > srctree even if S!=WORKDIR. The files must be placed under the
> > 'local-files' subdirectory.
> > 
> > Complements the previous patch that imports local files into srctree.
> > 
> > [YOCTO #7602]
> > 
> > Signed-off-by: Markus Lehtonen <markus.lehtonen@linux.intel.com>
> > ---
> >  scripts/lib/devtool/standard.py | 9 +++++++--
> >  1 file changed, 7 insertions(+), 2 deletions(-)
> > 
> > diff --git a/scripts/lib/devtool/standard.py
> > b/scripts/lib/devtool/standard.py index 6b85c8c..78b0d27 100644
> > --- a/scripts/lib/devtool/standard.py
> > +++ b/scripts/lib/devtool/standard.py
> > @@ -558,8 +558,13 @@ def modify(args, config, basepath, workspace):
> >      if not os.path.exists(appendpath):
> >          os.makedirs(appendpath)
> >      with open(appendfile, 'w') as f:
> > -        f.write('FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"\n\n')
> > -        f.write('inherit externalsrc\n')
> > +        f.write('FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"\n')
> > +        # Local files can be modified/tracked in separate subdir under
> > srctree +        # Mostly useful for packages with S != WORKDIR
> > +        f.write('FILESPATH_prepend := "%s:"\n' %
> > +                os.path.join(srctree, 'local-files'))
> 
> Shouldn't this directory be named "oe-local-files"?

Argh, sorry, I had missed this email earlier. Yes, it should be
'oe-local-files'. An updated patch with a fix is available at:

http://cgit.openembedded.org/openembedded-core-contrib/log/?h=marquiz/devtool/localfiles



Thanks,
  Markus



  reply	other threads:[~2015-09-30  9:01 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-24 11:52 [PATCH v3 00/10] devtool: improve handling of local source files Markus Lehtonen
2015-09-24 11:52 ` [PATCH v3 01/10] recipeutils: implement get_recipe_local_files() Markus Lehtonen
2015-09-24 11:52 ` [PATCH v3 02/10] oe.patch.GitApplyTree: add paths argument to extractPatches Markus Lehtonen
2015-09-24 11:53 ` [PATCH v3 03/10] oe-selftest: devtool: add method for checking workspace dir Markus Lehtonen
2015-09-28 20:25   ` Leonardo Sandoval
2015-09-29 10:57     ` Markus Lehtonen
2015-09-29 12:38       ` Markus Lehtonen
2015-09-24 11:53 ` [PATCH v3 04/10] oe-selftest: devtool: add method for checking srctree repo Markus Lehtonen
2015-09-24 11:53 ` [PATCH v3 05/10] oe-selftest: devtool: add method for checking repo status Markus Lehtonen
2015-09-24 11:53 ` [PATCH v3 06/10] devtool: update-recipe: add new patches in correct order Markus Lehtonen
2015-09-24 11:53 ` [PATCH v3 07/10] devtool: update_recipe: refactor patch generation Markus Lehtonen
2015-09-24 11:53 ` [PATCH v3 08/10] devtool: file mover function that creates target dir Markus Lehtonen
2015-09-24 11:53 ` [PATCH v3 09/10] devtool: better support for local source files Markus Lehtonen
2015-09-24 11:53 ` [PATCH v3 10/10] devtool: modify: make bitbake use local files from srctree Markus Lehtonen
2015-09-28 13:48   ` Paul Eggleton
2015-09-30  9:01     ` Markus Lehtonen [this message]
2015-09-30  9:21       ` Paul Eggleton
2015-09-30 10:05         ` Markus Lehtonen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1443603673.11206.35.camel@linux.intel.com \
    --to=markus.lehtonen@linux.intel.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=paul.eggleton@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox