From: Paul Eggleton <paul.eggleton@linux.intel.com>
To: openembedded-core@lists.openembedded.org
Cc: Koen Kooi <koen@dominion.thruhere.net>
Subject: Re: [PATCH/RFC] xorg-lib: don't build libs unless requested by DISTRO_FEATURES
Date: Fri, 10 Feb 2012 12:19:50 +0000 [thread overview]
Message-ID: <1443906.UPv3ikXssj@helios> (raw)
In-Reply-To: <7113E9EE-BFA2-47CA-94A5-381601F92C7F@dominion.thruhere.net>
On Friday 10 February 2012 09:38:59 Koen Kooi wrote:
> I know you're just moving the error message around, but I would suggest
> changing it to "'x11' not in DISTRO_FEATURES".
You have to be careful with this, as it will pick up partial words e.g.
assuming we had an "x11test" DISTRO_FEATURE then this would also be picked up
by this statement; whereas oe.utils.contains() does a split to make it a list
first and therefore does not have this issue. I'd suggest leaving it as-is, or
if you really want to change it, do a split on the string first.
Cheers,
Paul
--
Paul Eggleton
Intel Open Source Technology Centre
next prev parent reply other threads:[~2012-02-10 12:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-10 1:27 [PATCH/RFC] xorg-lib: don't build libs unless requested by DISTRO_FEATURES Andreas Oberritter
2012-02-10 8:38 ` Koen Kooi
2012-02-10 12:19 ` Paul Eggleton [this message]
2012-02-10 12:26 ` [PATCH/RFC v2] " Andreas Oberritter
2012-02-10 12:41 ` Paul Eggleton
2012-02-10 12:42 ` Koen Kooi
2012-02-24 18:28 ` [PATCH/RFC] " Saul Wold
2012-02-24 18:40 ` Andreas Oberritter
2012-02-26 11:42 ` Richard Purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1443906.UPv3ikXssj@helios \
--to=paul.eggleton@linux.intel.com \
--cc=koen@dominion.thruhere.net \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox