From: Andre McCurdy <armccurdy@gmail.com>
To: openembedded-core@lists.openembedded.org
Subject: [PATCH 6/7] busybox.inc: fix CONFIG_EXTRA_CFLAGS configmangle
Date: Mon, 5 Oct 2015 20:19:27 -0700 [thread overview]
Message-ID: <1444101568-16639-7-git-send-email-armccurdy@gmail.com> (raw)
In-Reply-To: <1444101568-16639-1-git-send-email-armccurdy@gmail.com>
With current busybox Kbuild, setting .config to:
CONFIG_EXTRA_CFLAGS="foo" "bar"
and then running 'make oldconfig' results in .config containing:
CONFIG_EXTRA_CFLAGS="foo"
ie the CONFIG_EXTRA_CFLAGS configmangle in the busybox.inc doesn't
currently work as intended. Remove the extra \" \" to ensure that
${HOST_CC_ARCH} gets added to CONFIG_EXTRA_CFLAGS.
Signed-off-by: Andre McCurdy <armccurdy@gmail.com>
---
meta/recipes-core/busybox/busybox.inc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta/recipes-core/busybox/busybox.inc b/meta/recipes-core/busybox/busybox.inc
index 48a28bc..b380860 100644
--- a/meta/recipes-core/busybox/busybox.inc
+++ b/meta/recipes-core/busybox/busybox.inc
@@ -97,7 +97,7 @@ python () {
("\\n".join((d.expand("${OE_FEATURES}").split("\n")))))
d.setVar('configmangle_append',
"/^### CROSS$/a\\\n%s\n" %
- ("\\n".join(["CONFIG_EXTRA_CFLAGS=\"${CFLAGS}\" \"${HOST_CC_ARCH}\""
+ ("\\n".join(["CONFIG_EXTRA_CFLAGS=\"${CFLAGS} ${HOST_CC_ARCH}\""
])
))
}
--
1.9.1
next prev parent reply other threads:[~2015-10-06 3:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-06 3:19 [PATCH 0/7] busybox fixes and cleanups Andre McCurdy
2015-10-06 3:19 ` [PATCH 1/7] busybox_git: Enable getopt applet Andre McCurdy
2015-10-06 3:19 ` [PATCH 2/7] busybox.inc: don't export EXTRA_OEMAKE Andre McCurdy
2015-10-06 3:19 ` [PATCH 3/7] busybox: move common EXTRA_OEMAKE options into busybox.inc Andre McCurdy
2015-10-06 3:19 ` [PATCH 4/7] busybox.inc: explicitly include CC=${CC} on make command line Andre McCurdy
2015-10-06 3:19 ` [PATCH 5/7] busybox.inc: don't set .config CROSS_COMPILER_PREFIX Andre McCurdy
2015-10-06 3:19 ` Andre McCurdy [this message]
2015-10-06 3:19 ` [PATCH 7/7] busybox.inc: remove MAKEFLAGS over-ride from EXTRA_OEMAKE Andre McCurdy
2015-10-06 3:54 ` [PATCH 0/7] busybox fixes and cleanups Khem Raj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1444101568-16639-7-git-send-email-armccurdy@gmail.com \
--to=armccurdy@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox