Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Christopher Larson <clarson@kergoth.com>
Cc: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 3/5] populate_sdk_base: Ensure PKGDATA_DIR exists
Date: Fri, 23 Oct 2015 07:41:55 +0100	[thread overview]
Message-ID: <1445582515.21913.16.camel@linuxfoundation.org> (raw)
In-Reply-To: <CABcZAN=CGvq4Wmd_fZosRijgqTtfrcJAeG39T=VRc165sG=qsg@mail.gmail.com>

On Thu, 2015-10-22 at 21:11 -0700, Christopher Larson wrote:
> On Thu, Oct 22, 2015 at 8:30 PM, Randy Witt
> <randy.e.witt@linux.intel.com> wrote:
>         -do_populate_sdk[dirs] = "${TOPDIR}"
>         +do_populate_sdk[dirs] = "${TOPDIR} ${PKGDATA_DIR}"
> 
> I hope do_populate_sdk doesn't care where it's run from, as this
> doesn't just make sure the dir exists, it changes the dir the task
> runs in (the last entry in dirs is the cwd of the task).

I was trying to remember which way around that was and planned to check
before merging. I agree this needs to be reversed (and the commit needs
a touch more explanation). I'll tweak that.

Cheers,

Richard




  reply	other threads:[~2015-10-23  6:42 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-23  3:30 [PATCH 0/5] Fix live images when using the extensible sdk Randy Witt
2015-10-23  3:30 ` [PATCH 1/5] Add 850 codepage to uninative-tarball Randy Witt
2015-10-23  3:30 ` [PATCH 2/5] scripts/oe-pkgdata-util: Fix variable name in error handling Randy Witt
2015-10-23  3:30 ` [PATCH 3/5] populate_sdk_base: Ensure PKGDATA_DIR exists Randy Witt
2015-10-23  4:11   ` Christopher Larson
2015-10-23  6:41     ` Richard Purdie [this message]
2015-10-23  3:30 ` [PATCH 4/5] mtools_4.0.18.bb: Use create_wrapper() for mcopy Randy Witt
2015-10-23  3:30 ` [PATCH 5/5] wic/utils/oe/misc.py: Preserve PATH when running native tools Randy Witt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1445582515.21913.16.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=clarson@kergoth.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox