Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Andre McCurdy <armccurdy@gmail.com>
To: openembedded-core@lists.openembedded.org
Subject: [PATCH 03/11] busybox: move EXTRA_OEMAKE etc into busybox.inc
Date: Fri,  6 Nov 2015 00:47:03 -0800	[thread overview]
Message-ID: <1446799631-7037-4-git-send-email-armccurdy@gmail.com> (raw)
In-Reply-To: <1446799631-7037-1-git-send-email-armccurdy@gmail.com>

EXTRA_OEMAKE and do_install_ptest() are currently common to all supported
versions of busybox, so move from version specific recipes into busybox.inc.

Signed-off-by: Andre McCurdy <armccurdy@gmail.com>
---
 meta/recipes-core/busybox/busybox.inc       | 7 +++++++
 meta/recipes-core/busybox/busybox_1.23.2.bb | 8 --------
 meta/recipes-core/busybox/busybox_git.bb    | 8 --------
 3 files changed, 7 insertions(+), 16 deletions(-)

diff --git a/meta/recipes-core/busybox/busybox.inc b/meta/recipes-core/busybox/busybox.inc
index 5e59ca7..48a012c 100644
--- a/meta/recipes-core/busybox/busybox.inc
+++ b/meta/recipes-core/busybox/busybox.inc
@@ -19,6 +19,7 @@ export EXTRA_CFLAGS = "${CFLAGS}"
 export EXTRA_LDFLAGS = "${LDFLAGS}"
 
 EXTRA_OEMAKE += "'LD=${CCLD}'"
+EXTRA_OEMAKE += "V=1 ARCH=${TARGET_ARCH} CROSS_COMPILE=${TARGET_PREFIX} SKIP_STRIP=y"
 
 PACKAGES =+ "${PN}-httpd ${PN}-udhcpd ${PN}-udhcpc ${PN}-syslog ${PN}-mdev ${PN}-hwclock"
 
@@ -301,6 +302,12 @@ do_install () {
     fi
 }
 
+do_install_ptest () {
+        cp -r ${B}/testsuite ${D}${PTEST_PATH}/
+        cp ${B}/.config      ${D}${PTEST_PATH}/
+        ln -s /bin/busybox   ${D}${PTEST_PATH}/busybox
+}
+
 inherit update-alternatives
 
 ALTERNATIVE_PRIORITY = "50"
diff --git a/meta/recipes-core/busybox/busybox_1.23.2.bb b/meta/recipes-core/busybox/busybox_1.23.2.bb
index 2559823..e9f7eb6 100644
--- a/meta/recipes-core/busybox/busybox_1.23.2.bb
+++ b/meta/recipes-core/busybox/busybox_1.23.2.bb
@@ -43,11 +43,3 @@ SRC_URI = "http://www.busybox.net/downloads/busybox-${PV}.tar.bz2;name=tarball \
 
 SRC_URI[tarball.md5sum] = "7925683d7dd105aabe9b6b618d48cc73"
 SRC_URI[tarball.sha256sum] = "05a6f9e21aad8c098e388ae77de7b2361941afa7157ef74216703395b14e319a"
-
-EXTRA_OEMAKE += "V=1 ARCH=${TARGET_ARCH} CROSS_COMPILE=${TARGET_PREFIX} SKIP_STRIP=y"
-
-do_install_ptest () {
-        cp -r ${B}/testsuite ${D}${PTEST_PATH}/
-        cp ${B}/.config      ${D}${PTEST_PATH}/
-        ln -s /bin/busybox   ${D}${PTEST_PATH}/busybox
-}
diff --git a/meta/recipes-core/busybox/busybox_git.bb b/meta/recipes-core/busybox/busybox_git.bb
index ed1c0a8..e9ff0bc 100644
--- a/meta/recipes-core/busybox/busybox_git.bb
+++ b/meta/recipes-core/busybox/busybox_git.bb
@@ -44,12 +44,4 @@ SRC_URI = "git://busybox.net/busybox.git \
            file://getopts.cfg \
 "
 
-EXTRA_OEMAKE += "V=1 ARCH=${TARGET_ARCH} CROSS_COMPILE=${TARGET_PREFIX} SKIP_STRIP=y"
-
-do_install_ptest () {
-        cp -r ${B}/testsuite ${D}${PTEST_PATH}/
-        cp ${B}/.config      ${D}${PTEST_PATH}/
-        ln -s /bin/busybox   ${D}${PTEST_PATH}/busybox
-}
-
 DEFAULT_PREFERENCE = "-1"
-- 
1.9.1



  parent reply	other threads:[~2015-11-06  8:47 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-06  8:47 [PATCH 00/11] busybox fixes and cleanups + update 1.23.2 -> 1.24.1 Andre McCurdy
2015-11-06  8:47 ` [PATCH 01/11] busybox_git: Enable getopt applet Andre McCurdy
2015-11-06  8:47 ` [PATCH 02/11] busybox.inc: don't export EXTRA_OEMAKE Andre McCurdy
2015-11-06  8:47 ` Andre McCurdy [this message]
2015-11-06  8:47 ` [PATCH 04/11] busybox.inc: explicitly include CC=${CC} on make command line Andre McCurdy
2015-11-06  8:47 ` [PATCH 05/11] busybox.inc: don't set .config CROSS_COMPILER_PREFIX Andre McCurdy
2015-11-06  8:47 ` [PATCH 06/11] busybox.inc: fix CONFIG_EXTRA_CFLAGS configmangle Andre McCurdy
2015-11-06  8:47 ` [PATCH 07/11] busybox.inc: remove MAKEFLAGS over-ride from EXTRA_OEMAKE Andre McCurdy
2015-11-06  8:47 ` [PATCH 08/11] busybox: re-order defconfig to align with busybox 1.24.1 Andre McCurdy
2015-11-06  8:47 ` [PATCH 09/11] busybox: update 1.23.2 -> 1.24.1 Andre McCurdy
2015-11-06  8:47 ` [PATCH 10/11] busybox: disable support for mounting NFS file systems on Linux < 2.6.23 Andre McCurdy
2015-11-06  8:47 ` [PATCH 11/11] busybox: enable resize applet Andre McCurdy
2015-11-19 21:08 ` [PATCH 00/11] busybox fixes and cleanups + update 1.23.2 -> 1.24.1 Andre McCurdy
2015-11-20 16:01   ` Ross Burton
  -- strict thread matches above, loose matches on Subject: below --
2015-11-20 22:43 [PATCH v2 " Andre McCurdy
2015-11-20 22:43 ` [PATCH 03/11] busybox: move EXTRA_OEMAKE etc into busybox.inc Andre McCurdy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1446799631-7037-4-git-send-email-armccurdy@gmail.com \
    --to=armccurdy@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox