From: Andre McCurdy <armccurdy@gmail.com>
To: openembedded-core@lists.openembedded.org
Subject: [PATCH 05/11] busybox.inc: fix CONFIG_EXTRA_CFLAGS configmangle
Date: Fri, 20 Nov 2015 14:43:52 -0800 [thread overview]
Message-ID: <1448059438-24431-6-git-send-email-armccurdy@gmail.com> (raw)
In-Reply-To: <1448059438-24431-1-git-send-email-armccurdy@gmail.com>
With current busybox Kbuild, setting .config to:
CONFIG_EXTRA_CFLAGS="foo" "bar"
and then running 'make oldconfig' results in .config containing:
CONFIG_EXTRA_CFLAGS="foo"
ie the CONFIG_EXTRA_CFLAGS configmangle in the busybox.inc doesn't
currently work as intended. Remove the extra \" \" to ensure that
${HOST_CC_ARCH} gets added to CONFIG_EXTRA_CFLAGS.
Signed-off-by: Andre McCurdy <armccurdy@gmail.com>
---
meta/recipes-core/busybox/busybox.inc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta/recipes-core/busybox/busybox.inc b/meta/recipes-core/busybox/busybox.inc
index 57da1db..03b6cf2 100644
--- a/meta/recipes-core/busybox/busybox.inc
+++ b/meta/recipes-core/busybox/busybox.inc
@@ -96,7 +96,7 @@ python () {
("\\n".join((d.expand("${OE_FEATURES}").split("\n")))))
d.setVar('configmangle_append',
"/^### CROSS$/a\\\n%s\n" %
- ("\\n".join(["CONFIG_EXTRA_CFLAGS=\"${CFLAGS}\" \"${HOST_CC_ARCH}\""
+ ("\\n".join(["CONFIG_EXTRA_CFLAGS=\"${CFLAGS} ${HOST_CC_ARCH}\""
])
))
}
--
1.9.1
next prev parent reply other threads:[~2015-11-20 22:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-20 22:43 [PATCH v2 00/11] busybox fixes and cleanups + update 1.23.2 -> 1.24.1 Andre McCurdy
2015-11-20 22:43 ` [PATCH 01/11] busybox_git: Enable getopt applet Andre McCurdy
2015-11-20 22:43 ` [PATCH 02/11] busybox.inc: don't export EXTRA_OEMAKE Andre McCurdy
2015-11-20 22:43 ` [PATCH 03/11] busybox: move EXTRA_OEMAKE etc into busybox.inc Andre McCurdy
2015-11-20 22:43 ` [PATCH 04/11] busybox.inc: don't set .config CROSS_COMPILER_PREFIX Andre McCurdy
2015-11-20 22:43 ` Andre McCurdy [this message]
2015-11-20 22:43 ` [PATCH 06/11] busybox.inc: set CC=${CC} via make command line Andre McCurdy
2015-11-20 22:43 ` [PATCH 07/11] busybox.inc: remove '-e MAKEFLAGS=' from EXTRA_OEMAKE Andre McCurdy
2015-11-20 22:43 ` [PATCH 08/11] busybox: re-order defconfig to align with busybox 1.24.1 Andre McCurdy
2015-11-20 22:43 ` [PATCH 09/11] busybox: update 1.23.2 -> 1.24.1 Andre McCurdy
2015-11-20 22:43 ` [PATCH 10/11] busybox: disable support for mounting NFS file systems on Linux < 2.6.23 Andre McCurdy
2015-11-20 22:43 ` [PATCH 11/11] busybox: enable resize applet Andre McCurdy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1448059438-24431-6-git-send-email-armccurdy@gmail.com \
--to=armccurdy@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox