Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Saul Wold <saul.wold@intel.com>
To: Jianxun Zhang <jianxun.zhang@linux.intel.com>,
	 openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] Explicitly map ARCH to 32 or 64 bit for Intel machines
Date: Thu, 03 Dec 2015 15:31:45 -0800	[thread overview]
Message-ID: <1449185505.3199.49.camel@intel.com> (raw)
In-Reply-To: <1449183819-236473-1-git-send-email-jianxun.zhang@linux.intel.com>

On Thu, 2015-12-03 at 15:03 -0800, Jianxun Zhang wrote:
> For a bare-bone kernel recipe which specifies 32 bit x86 target,
> a 64 bit .config will be generated from do_configure task when
> building 32-bit qemux86, once all of these conditions are true:
> 
> () arch of host is x86_64
> () kernel source tree used in build has commit ffee0de41 which
> actually chooses i386 or x86_64 defconfig by asking host arch if
> ARCH is "x86" (arch/x86/Makefile)
> () bare-bone kernel recipe inherits directly from kernel without
> other special treatment
> 
> Build will fail in this case because of the mismatched architecture
> of kernel image after compiling.
> 
> The patch sets ARCH i386 or x86_64 explicitly to configure
> task to avoid this host contamination.
> 
Just to be clear about this, it does not change the TUNE_ARCH, the ARCH
that is set is local to the kernel-arch.bbclass.

This should also be a candidate for backport to Jethro

Sau!

> Signed-off-by: Jianxun Zhang <jianxun.zhang@linux.intel.com>
> ---
>  meta/classes/kernel-arch.bbclass | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/meta/classes/kernel-arch.bbclass b/meta/classes/kernel-
> arch.bbclass
> index 3ed5986..d8b180e 100644
> --- a/meta/classes/kernel-arch.bbclass
> +++ b/meta/classes/kernel-arch.bbclass
> @@ -21,7 +21,9 @@ def map_kernel_arch(a, d):
>  
>      valid_archs = d.getVar('valid_archs', True).split()
>  
> -    if   re.match('(i.86|athlon|x86.64)$', a):  return 'x86'
> +    if   re.match('i.86$', a):                  return 'i386'
> +    elif re.match('x86.64$', a):                return 'x86_64'
> +    elif re.match('athlon$', a):                return 'x86'
>      elif re.match('armeb$', a):                 return 'arm'
>      elif re.match('aarch64$', a):               return 'arm64'
>      elif re.match('aarch64_be$', a):            return 'arm64'
> -- 
> 1.9.1
> 


  reply	other threads:[~2015-12-03 23:31 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-03 23:03 [PATCH] Explicitly map ARCH to 32 or 64 bit for Intel machines Jianxun Zhang
2015-12-03 23:31 ` Saul Wold [this message]
2015-12-10  0:07   ` Burton, Ross

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1449185505.3199.49.camel@intel.com \
    --to=saul.wold@intel.com \
    --cc=jianxun.zhang@linux.intel.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox