Re: [PATCH 1/2] cantarell-fonts: Add recipe

Jussi Kukkonen
2016-02-09T14:37:50Z

[-- Attachment #1: Type: text/plain, Size: 2731 bytes --]

Hi again,

Maybe this does make sense even with the downsides I mentioned earlier:
testing the layout is a good idea (even if just using font metrics), and
the build/install time/size of cantarell are reasonable. The test in
question seems good to me and these patches produce correct results.

A recipe review comment below.

Jussi

On 9 January 2016 at 16:32, Jagadeesh Krishnanjanappa <
jkrishnanjanappa@mvista.com> wrote:
>
> 1. The Cantarell font typeface is designed as a
> contemporary Humanist sans serif, and was developed for
> on-screen reading; in particular, reading web pages on an
> HTC Dream mobile phone.
>
> 2. Pango test case (test-layout.test) requires cantarell-font
> typeface. This test case uses 'Cantarell 11' font type
>
> Signed-off-by: Jagadeesh Krishnanjanappa <jkrishnanjanappa@mvista.com>
> ---
> .../cantarell-fonts/cantarell-fonts_git.bb | 25
++++++++++++++++++++++
> 1 file changed, 25 insertions(+)
> create mode 100644 meta/recipes-graphics/cantarell-fonts/
cantarell-fonts_git.bb
>
> diff --git a/meta/recipes-graphics/cantarell-fonts/cantarell-fonts_git.bb
b/meta/recipes-graphics/cantarell-fonts/cantarell-fonts_git.bb
> new file mode 100644
> index 0000000..f55fef1
> --- /dev/null
> +++ b/meta/recipes-graphics/cantarell-fonts/cantarell-fonts_git.bb
> @@ -0,0 +1,25 @@
> +SUMMARY = "Cantarell, a Humanist sans-serif font family"
> +
> +DESCRIPTION = "The Cantarell font typeface is designed as a \
> + contemporary Humanist sans serif, and was developed for \
> + on-screen reading; in particular, reading web pages on an
\
> + HTC Dream mobile phone."
> +
> +HOMEPAGE = "https://git.gnome.org/browse/cantarell-fonts/"
> +SECTION = "fonts"
> +LICENSE = "OFL-1.1"
> +LIC_FILES_CHKSUM = "file://COPYING;md5=df91e3ffcab8cfb972a66bf11255188d"
> +
> +PV = "0.0.18.1+git${SRCPV}"

We could go with 0.0.21 since that's now out (I realize you picked the
newest release at the time -- sorry for extra work).

> +PR = "r0"

PR is not needed.

> +
> +SRCREV = "3e954528d06de1c7e5ba8ebf8b0cca9c68faa0c4"
> +SRC_URI = "git://git.gnome.org/cantarell-fonts;protocol=git;branch=master
"
> +
> +S = "${WORKDIR}/git"
> +
> +inherit autotools allarch fontcache
> +
> +PACKAGECONFIG ??= ""
> +PACKAGECONFIG[fontforge] =
"--enable-source-rebuild=yes,--enable-source-rebuild=no,fontforge-native"
> +FILES_${PN} = "${datadir}/fonts ${datadir}/fontconfig"
> --
> 1.9.1
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core

[-- Attachment #2: Type: text/html, Size: 3899 bytes --]