From: Phil Blundell <pb@pbcl.net>
To: Khem Raj <raj.khem@gmail.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] matchbox-keyboard: Fix build failure with ld-is-gold
Date: Thu, 14 Jan 2016 21:22:34 +0000 [thread overview]
Message-ID: <1452806554.26165.0.camel@pbcl.net> (raw)
In-Reply-To: <3FF112F9-6E3D-4A9E-9A1D-AA30AF596FD6@gmail.com>
How does that patch help with this issue? It seems to be adding ifunc
support which isn't obviously related to the problem at hand.
p.
On Thu, 2016-01-14 at 10:27 -0800, Khem Raj wrote:
> Carlos
>
> Can you try this fix
>
> https://github.com/kraj/openembedded-core/commit/0e35ad5a35262cfb7a6249ce158f76d1399d6cb4
>
>
> This should help with this issue.
>
>
> > On Sep 14, 2015, at 4:01 PM, Carlos Alberto Lopez Perez <clopez@igalia.com> wrote:
> >
> > On 14/09/15 09:24, Khem Raj wrote:
> >>
> >>> On Sep 11, 2015, at 7:51 AM, Phil Blundell <pb@pbcl.net> wrote:
> >>>
> >>> On Fri, 2015-09-11 at 14:49 +0200, Carlos Alberto Lopez Perez wrote:
> >>>> * When ld-is-gold is enabled in DISTRO_FEATURES, matchbox-keyboard
> >>>> will fail to build with this error:
> >>>>
> >>>> ld: error: matchbox-keyboard-image.o: requires unsupported dynamic
> >>>> reloc R_ARM_MOVW_ABS_NC; recompile with -fPIC
> >>>
> >>> This is only an issue for ARM (and only for Thumb2 at that). I don't
> >>> think it's necessarily appropriate to force -fPIC on all targets.
> >>>
> >>> Also, before adding this sort of hack it would be worth verifying
> >>> whether this is in fact a toolchain bug and, if it is, fixing it there.
> >>>
> >>
> >> This may not be a toolchain bug if there is a MOVW_ABS relocation being emitted
> >> into an object that is eventually linked into shared library. Using -fPIC seems to be right fix
> >> I know bfd linker silently ignored these relocations and generated bad .so files but that was fixed
> >> several years ago. So I think what needs to be looked at is why does same .o links ok with bfd linker
> >> is it some linker trampoline code thats in question here which may be different between gold and ld
> >>
> >> Carlos
> >>
> >> Can you check the linker cmdline of failing link step and see if its generating a shared object there ?
> >> if thats the case and I assume gcc is generating this relocation into both
> >>
> >
> > It looks is generating an executable (matchbox-keyboard).
> >
> > Full log: http://sprunge.us/VPIN
> >
>
next prev parent reply other threads:[~2016-01-14 21:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-11 12:49 [PATCH] matchbox-keyboard: Fix build failure with ld-is-gold Carlos Alberto Lopez Perez
2015-09-11 14:51 ` Phil Blundell
2015-09-11 16:46 ` Carlos Alberto Lopez Perez
2015-09-14 7:24 ` Khem Raj
2015-09-14 23:01 ` Carlos Alberto Lopez Perez
2016-01-14 18:27 ` Khem Raj
2016-01-14 21:22 ` Phil Blundell [this message]
2016-01-17 11:15 ` Khem Raj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1452806554.26165.0.camel@pbcl.net \
--to=pb@pbcl.net \
--cc=openembedded-core@lists.openembedded.org \
--cc=raj.khem@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox