From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Martin Jansa <martin.jansa@gmail.com>,
Robert Yang <liezhi.yang@windriver.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 1/1] gstreamer1.0-plugins-good.inc: add gudev back to PACKAGECONFIG
Date: Mon, 18 Jan 2016 17:52:31 +0000 [thread overview]
Message-ID: <1453139551.27999.75.camel@linuxfoundation.org> (raw)
In-Reply-To: <20160118165317.GC2614@jama>
On Mon, 2016-01-18 at 17:53 +0100, Martin Jansa wrote:
> On Fri, Jan 15, 2016 at 01:07:20AM -0800, Robert Yang wrote:
> > The 66e32244aed8d33f1b49fbe78179f2442545c730 wrongly removed gudev
> > from
> > PACKAGECONFIG, now add it back.
>
> It was removed intentionally, because for systemd images there isn't
> libgudev provider in oe-core, only in meta-oe.
>
> RP's fix:
> http://git.openembedded.org/openembedded-core/commit/?h=jethro&id=bc4
> 58ae9586b45b11b6908eadb31e94d892e698f
>
> breaks the dependencies again, because when systemd is used there
> won't
> be libgudev needed by gstreamer1.0-plugins-good
>
> Please revert both "fixes"
The "backported" patch should have made mention of the changes compared
to the version in master since otherwise, "intentionally" looked like a
mistake :/.
What is the impact to gstreamer of removing libgudev?
Cheers,
Richard
next prev parent reply other threads:[~2016-01-18 17:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-15 9:07 [jethro] [PATCH 0/1] gstreamer1.0-plugins-good.inc: add gudev back to PACKAGECONFIG Robert Yang
2016-01-15 9:07 ` [PATCH 1/1] " Robert Yang
2016-01-18 16:53 ` Martin Jansa
2016-01-18 17:52 ` Richard Purdie [this message]
2016-01-19 1:40 ` Robert Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1453139551.27999.75.camel@linuxfoundation.org \
--to=richard.purdie@linuxfoundation.org \
--cc=liezhi.yang@windriver.com \
--cc=martin.jansa@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox