From: Andre McCurdy <armccurdy@gmail.com>
To: openembedded-core@lists.openembedded.org
Subject: [PATCH v2 1/3] valgrind: let valgrind determine its own optimisation flags
Date: Tue, 19 Jan 2016 18:47:49 -0800 [thread overview]
Message-ID: <1453258071-22847-2-git-send-email-armccurdy@gmail.com> (raw)
In-Reply-To: <1453258071-22847-1-git-send-email-armccurdy@gmail.com>
Valgrind likes to control its own optimisation flags. It generally
defaults to -O2 but uses -O0 for some specific test apps etc. Passing
our own flags (via CFLAGS) means we interfere with that.
Giving valgrind control of optimisation is hopefully an even better
solution than the previous one of forcing -O0 for all tests.
http://git.openembedded.org/openembedded-core/commit/?h=master-next&id=98c4a3ffb8dca10739be600e8d6df7fb6aa4958f
Signed-off-by: Andre McCurdy <armccurdy@gmail.com>
---
meta/recipes-devtools/valgrind/valgrind_3.11.0.bb | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/meta/recipes-devtools/valgrind/valgrind_3.11.0.bb b/meta/recipes-devtools/valgrind/valgrind_3.11.0.bb
index 70d84fe..8e9b72c 100644
--- a/meta/recipes-devtools/valgrind/valgrind_3.11.0.bb
+++ b/meta/recipes-devtools/valgrind/valgrind_3.11.0.bb
@@ -44,6 +44,11 @@ EXTRA_OECONF_append_arm = " --host=armv7${HOST_VENDOR}-${HOST_OS}"
EXTRA_OEMAKE = "-w"
+# valgrind likes to control its own optimisation flags. It generally defaults
+# to -O2 but uses -O0 for some specific test apps etc. Passing our own flags
+# (via CFLAGS) means we interfere with that.
+SELECTED_OPTIMIZATION = ""
+
CFLAGS_append_libc-uclibc = " -D__UCLIBC__ "
do_install_append () {
@@ -63,10 +68,9 @@ RDEPENDS_${PN}-ptest += " sed perl glibc-utils perl-module-file-glob"
INSANE_SKIP_${PN}-ptest += "file-rdeps"
do_compile_ptest() {
- oe_runmake check CFLAGS="${CFLAGS} -O0" CXXFLAGS="${CXXFLAGS} -O0"
+ oe_runmake check
}
-
do_install_ptest() {
chmod +x ${B}/tests/vg_regtest
@@ -107,4 +111,3 @@ do_install_ptest() {
# handle multilib
sed -i s:@libdir@:${libdir}:g ${D}${PTEST_PATH}/run-ptest
}
-
--
1.9.1
next prev parent reply other threads:[~2016-01-20 2:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-20 2:47 [PATCH v2 0/3] valgrind cleanup + fix for armv7a without vfp/neon Andre McCurdy
2016-01-20 2:47 ` Andre McCurdy [this message]
2016-01-20 2:47 ` [PATCH v2 2/3] valgrind: re-enable ARM intdiv and vcvt_fixed_float_VFP tests Andre McCurdy
2016-01-20 3:00 ` Rongqing Li
2016-01-20 2:47 ` [PATCH v2 3/3] valgrind: avoid neon for targets which don't support it Andre McCurdy
2016-01-20 3:00 ` Rongqing Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1453258071-22847-2-git-send-email-armccurdy@gmail.com \
--to=armccurdy@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox