From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Paul Eggleton <paul.eggleton@linux.intel.com>,
openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 1/1] insane.bbclass: do_package_qa depends on WARN_QA and ERROR_QA
Date: Thu, 21 Jan 2016 21:56:18 +0000 [thread overview]
Message-ID: <1453413378.27999.173.camel@linuxfoundation.org> (raw)
In-Reply-To: <2992852.OT1HfBaFUF@peggleto-mobl.ger.corp.intel.com>
On Fri, 2016-01-22 at 07:29 +1300, Paul Eggleton wrote:
> On Thu, 21 Jan 2016 16:42:00 Robert Yang wrote:
> > On 01/21/2016 04:16 PM, Olof Johansson wrote:
> > > On 16-01-21 00:11 -0800, Robert Yang wrote:
> > > > --- a/meta/classes/insane.bbclass
> > > > +++ b/meta/classes/insane.bbclass
> > > > @@ -1098,6 +1098,7 @@ python do_package_qa () {
> > > >
> > > > do_package_qa[vardepsexclude] = "BB_TASKDEPDATA"
> > > > do_package_qa[rdeptask] = "do_packagedata"
> > > >
> > > > +do_package_qa[vardeps] += "${WARN_QA} ${ERROR_QA}"
> > >
> > > Shouldn't this be "WARN_QA ERROR_QA"? Or you'll get the expanded
> > > values of the variables.
> >
> > Sorry, please drop this patch, need more work it.
>
> Aside from that, didn't we already have a discussion on whether
> changing these
> variables should force do_package_qa to re-execute? Ross, I seem to
> recall you
> were involved last time.
Last time around we ended up with:
http://git.yoctoproject.org/cgit.cgi/poky/commit/?id=f6ec8dfaf7f98ade05d6292d2fea42805c4d80a7
Cheers,
Richard
next prev parent reply other threads:[~2016-01-21 21:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-21 8:11 [PATCH 0/1] insane.bbclass: do_package_qa depends on WARN_QA and ERROR_QA Robert Yang
2016-01-21 8:11 ` [PATCH 1/1] " Robert Yang
2016-01-21 8:16 ` Olof Johansson
2016-01-21 8:42 ` Robert Yang
2016-01-21 18:29 ` Paul Eggleton
2016-01-21 21:56 ` Richard Purdie [this message]
2016-01-21 22:04 ` Burton, Ross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1453413378.27999.173.camel@linuxfoundation.org \
--to=richard.purdie@linuxfoundation.org \
--cc=openembedded-core@lists.openembedded.org \
--cc=paul.eggleton@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox