From: Phil Blundell <pb@pbcl.net>
To: Hongxu Jia <hongxu.jia@windriver.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 4/5] glibc.inc: do not immediate expand SELECTED_OPTIMIZATION
Date: Sat, 30 Jan 2016 10:35:58 +0000 [thread overview]
Message-ID: <1454150158.7421.5.camel@pbcl.net> (raw)
In-Reply-To: <89d0983784390cce5fd975199443c874ee1b1295.1454088695.git.hongxu.jia@windriver.com>
On Fri, 2016-01-29 at 12:35 -0500, Hongxu Jia wrote:
> We need to expand SELECTED_OPTIMIZATION later, so
> do not immediate expansion, and do the work in
> anonymous python function.
>
> It is reasonable to give an error for -O0.
I applaud the general idea of this patch, but...
> + d.appendVar("SELECTED_OPTIMIZATION", " -Wno-error")
... can't you just use CFLAGS += -Wno-error rather than fiddling with
SELECTED_OPTIMIZATION here? -Wno-error is clearly not an optimization
flag.
p.
next prev parent reply other threads:[~2016-01-30 11:38 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-29 17:35 [PATCH v3 0/5]use target path to replace build ones in debugging info Hongxu Jia
2016-01-29 17:35 ` [PATCH 1/5] base/bbclass: use target path as compile dir " Hongxu Jia
2016-01-29 17:48 ` Peter Kjellerstedt
2016-01-30 1:15 ` Hongxu Jia
2016-01-29 17:35 ` [PATCH 2/5] gcc-5.3.inc/base.bbclass: add gcc option to not record -fdebug-prefix-map to " Hongxu Jia
2016-01-29 17:47 ` Peter Kjellerstedt
2016-01-30 1:25 ` Hongxu Jia
2016-01-30 2:36 ` Khem Raj
2016-01-30 10:57 ` Richard Purdie
2016-02-01 14:01 ` Hongxu Jia
2016-02-01 14:09 ` Richard Purdie
2016-02-01 17:10 ` Khem Raj
2016-02-07 16:17 ` Hongxu Jia
2016-01-30 11:43 ` Phil Blundell
2016-02-20 13:00 ` Martin Jansa
2016-02-20 15:02 ` Khem Raj
2016-02-22 6:44 ` Hongxu Jia
2016-02-22 15:35 ` Martin Jansa
2016-01-29 17:35 ` [PATCH 3/5] mkelfimage: fix target cflags leaks to host Hongxu Jia
2016-01-29 17:35 ` [PATCH 4/5] glibc.inc: do not immediate expand SELECTED_OPTIMIZATION Hongxu Jia
2016-01-30 10:35 ` Phil Blundell [this message]
2016-01-29 17:35 ` [PATCH 5/5] systemtap_git.inc: " Hongxu Jia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1454150158.7421.5.camel@pbcl.net \
--to=pb@pbcl.net \
--cc=hongxu.jia@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox