Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: openembedded-core <openembedded-core@lists.openembedded.org>
Subject: [PATCH] package.bbclass: Add data expansion to do_split_packages()
Date: Tue, 02 Feb 2016 13:52:38 +0000	[thread overview]
Message-ID: <1454421158.27087.59.camel@linuxfoundation.org> (raw)

do_split_packages is often called with parameters which need expansion.
This happens to work at the moment since python functions are expanded 
before execution but likely will not happen in future and isn't good 
code practise.

Expand the common parameters do_split_packages() to avoid regressions.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>

diff --git a/meta/classes/package.bbclass b/meta/classes/package.bbclass
index fdcf5ff..854591b 100644
--- a/meta/classes/package.bbclass
+++ b/meta/classes/package.bbclass
@@ -121,6 +121,8 @@ def do_split_packages(d, root, file_regex, output_pattern, description, postinst
     """
 
     dvar = d.getVar('PKGD', True)
+    root = d.expand(root)
+    output_pattern = d.expand(output_pattern)
 
     # If the root directory doesn't exist, don't error out later but silently do
     # no splitting.




                 reply	other threads:[~2016-02-02 13:52 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1454421158.27087.59.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox