From: Markus Lehtonen <markus.lehtonen@linux.intel.com>
To: "Burton, Ross" <ross.burton@intel.com>
Cc: OE-core <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 2/3] oe/gpg_sign: check for python-pexpect when using local signing
Date: Mon, 08 Feb 2016 12:52:39 +0200 [thread overview]
Message-ID: <1454928759.12961.3.camel@linux.intel.com> (raw)
In-Reply-To: <CAJTo0LaHHNGPTTLDnDai4ArYBkSZDQb+1tmQ18vPDpzH4ef_EQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 724 bytes --]
On Fri, 2016-02-05 at 14:31 +0000, Burton, Ross wrote:
>
> On 5 February 2016 at 14:00, Markus Lehtonen <
> markus.lehtonen@linux.intel.com> wrote:
> > + msgs.append("Please install python-pexpect that is
> > needed by lcocal gpg signing.")
> >
> Isn't this only needed if signing RPMs? Hopefully in the future this
> class will be used for more than RPM signing and detached signing
> doesn't need pexpect.
Yes, that is true. Any suggestions how to change this? Just try
ImportError in sign_rpms() and fail there(?)
> Also, typo in "local".
Typo fixed (and commit message modified) in my contrib repo:
git://git.openembedded.org/openembedded-core-contrib marquiz/rpmsign
Thanks,
Markus
[-- Attachment #2: Type: text/html, Size: 1522 bytes --]
next prev parent reply other threads:[~2016-02-08 10:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-05 14:00 [PATCH 0/3] signing: enhance sanity checking Markus Lehtonen
2016-02-05 14:00 ` [PATCH 1/3] package signing: do actual sanity checking in the signer class Markus Lehtonen
2016-02-05 14:00 ` [PATCH 2/3] oe/gpg_sign: check for python-pexpect when using local signing Markus Lehtonen
2016-02-05 14:31 ` Burton, Ross
2016-02-08 10:52 ` Markus Lehtonen [this message]
2016-02-08 11:17 ` Ioan-Adrian Ratiu
2016-02-05 14:00 ` [PATCH 3/3] package signing: do sanity checking in an event handler Markus Lehtonen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1454928759.12961.3.camel@linux.intel.com \
--to=markus.lehtonen@linux.intel.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=ross.burton@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox