From: Phil Blundell <pb@pbcl.net>
To: Khem Raj <raj.khem@gmail.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 1/9] distutils: Consider S != B case
Date: Wed, 10 Feb 2016 18:54:21 +0000 [thread overview]
Message-ID: <1455130461.7421.130.camel@pbcl.net> (raw)
In-Reply-To: <d7fb520732892e8f08f7817b7abd127b98fa6c1d.1455126045.git.raj.khem@gmail.com>
On Wed, 2016-02-10 at 17:43 +0000, Khem Raj wrote:
> + cwd=$PWD;cd ${S}
> + STAGING_INCDIR=${STAGING_INCDIR} \
> + STAGING_LIBDIR=${STAGING_LIBDIR} \
> + BUILD_SYS=${BUILD_SYS} HOST_SYS=${HOST_SYS} \
> + ${STAGING_BINDIR_NATIVE}/${PYTHON_PN}-native/${PYTHON_PN} ${S}/setup.py build --build-base=${B} ${DISTUTILS_BUILD_ARGS} || \
> + bbfatal "${PYTHON_PN} setup.py build execution failed."
> + cd $cwd
Why do you need to save and restore the cwd? If this is a shell task
then the "cd" would be local to that shell invocation anyway, right?
Also, given that you're invoking it by full pathname as
"${S}/setup.py ..." anyway, do you even need ${S} to be the cwd in the
first place? That seems a bit redundant.
p.
next prev parent reply other threads:[~2016-02-10 18:54 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-10 17:43 [PATCH 0/9] Upgrade uclibc/musl to latest Khem Raj
2016-02-10 17:43 ` [PATCH 1/9] distutils: Consider S != B case Khem Raj
2016-02-10 18:29 ` Richard Purdie
2016-02-10 18:53 ` Khem Raj
2016-02-10 18:54 ` Phil Blundell [this message]
2016-02-10 19:01 ` Khem Raj
2016-02-10 17:43 ` [PATCH 2/9] ltp: Upgrade to 20160126 and fix build on musl Khem Raj
2016-02-11 10:12 ` Richard Purdie
2016-02-11 16:13 ` Khem Raj
2016-02-10 17:43 ` [PATCH 3/9] musl: Upgrade to tip of tree Khem Raj
2016-02-10 17:43 ` [PATCH 4/9] uclibc-ng: Bump up to 1.0.12 release Khem Raj
2016-02-10 21:52 ` akuster808
2016-02-10 17:43 ` [PATCH 5/9] uclibc: fetch from master branch not 1.0 Khem Raj
2016-02-10 17:43 ` [PATCH 6/9] strace: build fix for MIPS + musl libc Khem Raj
2016-02-10 17:43 ` [PATCH 7/9] gdb: " Khem Raj
2016-02-10 17:43 ` [PATCH 8/9] gdb: drop unnecessary CC_FOR_BUILD etc exports Khem Raj
2016-02-10 17:43 ` [PATCH 9/9] nettle.inc: drop duplicate LIC_FILES_CHKSUM and SRC_URI hashes Khem Raj
2016-02-13 8:23 ` [PATCH 0/9] Upgrade uclibc/musl to latest Richard Purdie
2016-02-13 15:43 ` Khem Raj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1455130461.7421.130.camel@pbcl.net \
--to=pb@pbcl.net \
--cc=openembedded-core@lists.openembedded.org \
--cc=raj.khem@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox