From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Andre McCurdy <armccurdy@gmail.com>,
openembedded-core <openembedded-core@lists.openembedded.org>
Subject: [PATCH] gstreamer1.0-meta-base: Don't use COMBINED_FEATURES
Date: Fri, 12 Feb 2016 11:54:21 +0000 [thread overview]
Message-ID: <1455278061.16142.278.camel@linuxfoundation.org> (raw)
http://git.openembedded.org/openembedded-core/commit/?id=948165dce7475b815a344fd3c3d58165e6865d48
makes gstreamer1.0-plugins-base-alsa depend on COMBINED_FEATURES.
This is an allarch recipe so this only works if all your machines
have the same MACHINE_FEATURES and not all do.
Instead make this an unconditional RRECOMMEND, its a PACKAGES_DYNAMIC so
this should all work out for everyone's use cases.
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
diff --git a/meta/recipes-multimedia/gstreamer/gstreamer1.0-meta-base.bb b/meta/recipes-multimedia/gstreamer/gstreamer1.0-meta-base.bb
index ecfd082..9d1b9dc 100644
--- a/meta/recipes-multimedia/gstreamer/gstreamer1.0-meta-base.bb
+++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-meta-base.bb
@@ -26,7 +26,6 @@ RDEPENDS_gstreamer1.0-meta-base = "\
gstreamer1.0 \
gstreamer1.0-plugins-base-playback \
gstreamer1.0-plugins-base-gio \
- ${@bb.utils.contains('COMBINED_FEATURES', 'alsa', 'gstreamer1.0-plugins-base-alsa', '',d)} \
gstreamer1.0-plugins-base-volume \
gstreamer1.0-plugins-base-audioconvert \
gstreamer1.0-plugins-base-audioresample \
@@ -36,6 +35,10 @@ RDEPENDS_gstreamer1.0-meta-base = "\
gstreamer1.0-plugins-good-autodetect \
gstreamer1.0-plugins-good-souphttpsrc"
+RRECOMMENDS_gstreamer1.0-meta-base = "\
+ gstreamer1.0-plugins-base-alsa \
+"
+
RRECOMMENDS_gstreamer1.0-meta-x11-base = "\
gstreamer1.0-plugins-base-ximagesink \
gstreamer1.0-plugins-base-xvimagesink"
next reply other threads:[~2016-02-12 11:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-12 11:54 Richard Purdie [this message]
2016-02-12 22:17 ` [PATCH] gstreamer1.0-meta-base: Don't use COMBINED_FEATURES Andre McCurdy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1455278061.16142.278.camel@linuxfoundation.org \
--to=richard.purdie@linuxfoundation.org \
--cc=armccurdy@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox