From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Mike Crowe <mac@mcrowe.com>, openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 3/3] bitbake.conf: Remove unhelpful default value for EXTRA_OEMAKE
Date: Tue, 16 Feb 2016 12:28:03 +0000 [thread overview]
Message-ID: <1455625683.28376.1.camel@linuxfoundation.org> (raw)
In-Reply-To: <1454424587-4251-4-git-send-email-mac@mcrowe.com>
On Tue, 2016-02-02 at 14:49 +0000, Mike Crowe wrote:
> Setting EXTRA_OEMAKE to "-e MAKEFLAGS=" by default is a historical
> accident and many classes (e.g. autotools.bbclass, module.bbclass)
> and
> recipes have to override this default in order to work with sensible
> build systems.
>
> Now that openssl and pciutils have been fixed to set EXTRA_OEMAKE
> explicitly it is possible to set EXTRA_OEMAKE = "".
>
> Signed-off-by: Mike Crowe <mac@mcrowe.com>
> ---
> meta/conf/bitbake.conf | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
> index 1a2f420..a32d293 100644
> --- a/meta/conf/bitbake.conf
> +++ b/meta/conf/bitbake.conf
> @@ -474,7 +474,7 @@ export BUILD_STRIP = "${BUILD_PREFIX}strip"
> export BUILD_NM = "${BUILD_PREFIX}nm"
>
> export MAKE = "make"
> -EXTRA_OEMAKE = "-e MAKEFLAGS="
> +EXTRA_OEMAKE = ""
> EXTRA_OECONF = ""
> export LC_ALL = "C"
I've merged this.
I just wanted to say thanks for taking this on, it required a bit of
work but is a good improvement and something several people have wanted
to see for a long time!
Cheers,
Richard
next prev parent reply other threads:[~2016-02-16 12:28 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-02 14:49 [PATCH 0/3] Remove unhelpful default value of EXTRA_OEMAKE Mike Crowe
2016-02-02 14:49 ` [PATCH 1/3] openssl: Explicitly set EXTRA_OEMAKE as required Mike Crowe
2016-02-02 14:49 ` [PATCH 2/3] pciutils: " Mike Crowe
2016-02-02 14:49 ` [PATCH 3/3] bitbake.conf: Remove unhelpful default value for EXTRA_OEMAKE Mike Crowe
2016-02-16 12:28 ` Richard Purdie [this message]
2016-02-02 16:01 ` [PATCH 0/3] Remove unhelpful default value of EXTRA_OEMAKE Richard Purdie
2016-02-02 16:17 ` Martin Jansa
2016-02-06 17:32 ` Martin Jansa
2016-02-06 20:41 ` Mike Crowe
2016-02-07 22:07 ` Mike Crowe
2016-02-08 0:07 ` Martin Jansa
2016-02-09 10:39 ` Martin Jansa
2016-02-09 12:30 ` Mike Crowe
2016-02-09 12:51 ` Andrea Adami
2016-02-09 15:16 ` Mike Crowe
2016-02-02 21:04 ` Mike Crowe
2016-02-02 22:41 ` Richard Purdie
2016-02-05 17:32 ` Mike Crowe
2016-02-05 18:22 ` Khem Raj
2016-02-05 18:31 ` Richard Purdie
2016-02-05 18:35 ` Khem Raj
2016-02-06 17:43 ` Khem Raj
2016-02-05 18:35 ` Martin Jansa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1455625683.28376.1.camel@linuxfoundation.org \
--to=richard.purdie@linuxfoundation.org \
--cc=mac@mcrowe.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox