From: Benjamin Esquivel <benjamin.esquivel@linux.intel.com>
To: Alex Franco <alejandro.franco@linux.intel.com>,
openembedded-core@lists.openembedded.org
Subject: Re: [PATCHv2 2/2] testimage.bbclass: reuse generic test suites
Date: Tue, 23 Feb 2016 15:20:20 -0600 [thread overview]
Message-ID: <1456262420.13465.101.camel@linux.intel.com> (raw)
In-Reply-To: <1456218868-36139-3-git-send-email-alejandro.franco@linux.intel.com>
Hi Franco, how did you test this? what is the behavior you get with
these defaults instead of how's behaving now?
See comments below.
On Tue, 2016-02-23 at 09:14 +0000, Alex Franco wrote:
> Modify existing default test suites to reuse the new
> generic test suites.
>
> Related to [YOCTO #8410]
>
> Signed-off-by: Alex Franco <alejandro.franco@linux.intel.com>
> ---
> meta/classes/testimage.bbclass | 12 +++++++-----
> 1 file changed, 7 insertions(+), 5 deletions(-)
>
> diff --git a/meta/classes/testimage.bbclass
> b/meta/classes/testimage.bbclass
> index 791cce3..e77bb11 100644
> --- a/meta/classes/testimage.bbclass
> +++ b/meta/classes/testimage.bbclass
> @@ -37,17 +37,19 @@ MINTESTSUITE = "ping"
> NETTESTSUITE = "${MINTESTSUITE} ssh df date scp syslog"
> DEVTESTSUITE = "gcc kernelmodule ldd"
>
> -DEFAULT_TEST_SUITES = "ping auto"
> -DEFAULT_TEST_SUITES_pn-core-image-minimal = "ping"
> +DEFAULT_TEST_SUITES = "${MINTESTSUITE} auto"
> +DEFAULT_TEST_SUITES_pn-core-image-minimal = "${MINTESTSUITE}"
> DEFAULT_TEST_SUITES_pn-core-image-minimal-dev = "${MINTESTSUITE}"
> DEFAULT_TEST_SUITES_pn-core-image-full-cmdline = "${NETTESTSUITE}
> perl python logrotate"
> DEFAULT_TEST_SUITES_pn-core-image-x11 = "${MINTESTSUITE}"
> DEFAULT_TEST_SUITES_pn-core-image-lsb = "${NETTESTSUITE} pam
> parselogs ${RPMTESTSUITE}"
> -DEFAULT_TEST_SUITES_pn-core-image-sato = "ping ssh df connman syslog
> xorg scp date parselogs ${RPMTESTSUITE} \
> +DEFAULT_TEST_SUITES_pn-core-image-sato = "${NETTESTSUITE} connman
> xorg parselogs ${RPMTESTSUITE} \
> ${@bb.utils.contains('IMAGE_PKGTYPE', 'rpm', 'python', '', d)}"
> -DEFAULT_TEST_SUITES_pn-core-image-sato-sdk = "ping ssh df connman
> syslog xorg scp date perl ldd gcc kernelmodule python parselogs
> ${RPMTESTSUITE}"
> +DEFAULT_TEST_SUITES_pn-core-image-sato-sdk = "${NETTESTSUITE}
> connman xorg perl python \
> + ${DEVTESTSUITE} parselogs ${RPMTESTSUITE}"
> DEFAULT_TEST_SUITES_pn-core-image-lsb-dev = "${NETTESTSUITE} pam
> perl python parselogs ${RPMTESTSUITE}"
> -DEFAULT_TEST_SUITES_pn-core-image-lsb-sdk = "ping buildcvs
> buildiptables buildsudoku connman date df gcc kernelmodule ldd pam
> parselogs perl python scp ${RPMTESTSUITE} ssh syslog logrotate"
> +DEFAULT_TEST_SUITES_pn-core-image-lsb-sdk = "${NETTESTSUITE}
> buildcvs buildiptables buildsudoku \
> + connman ${DEVTESTSUITE} pam perl python parselogs
These lots of declarations seem to be suited for a .inc file instead of
living in the bbclass.
> ${RPMTESTSUITE}"
> DEFAULT_TEST_SUITES_pn-meta-toolchain = "auto"
>
> # aarch64 has no graphics
> --
> 2.6.2
>
next prev parent reply other threads:[~2016-02-23 21:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-23 9:14 [PATCHv2 0/2] testimage: add/modify DEFAULT_TEST_SUITES Alex Franco
2016-02-23 9:14 ` [PATCHv2 1/2] testimage.bbclass: add generic, image test suites Alex Franco
2016-02-23 9:14 ` [PATCHv2 2/2] testimage.bbclass: reuse generic " Alex Franco
2016-02-23 21:20 ` Benjamin Esquivel [this message]
2016-02-23 22:18 ` Alex Franco
2016-02-24 15:47 ` Benjamin Esquivel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1456262420.13465.101.camel@linux.intel.com \
--to=benjamin.esquivel@linux.intel.com \
--cc=alejandro.franco@linux.intel.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox