[PATCH v2] site: enable pthread support for x86_64 APR builds

[PATCH v2] site: enable pthread support for x86_64 APR builds

[Ioan-Adrian Ratiu]

The apache2 package is missing key pieces of pthread support (notably
pthread_kill) on x86_64 platforms. Fix this by setting cached variable
apr_cv_pthreads_cflags=-pthread which will trickle down into apache2 as
well. powerpc32-linux currently sets this option.

Suggested-by: Jacob Champion <jacob.champion@ni.com>
Signed-off-by: Ioan-Adrian Ratiu <adrian.ratiu@ni.com>
---
 meta/site/x86_64-linux | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meta/site/x86_64-linux b/meta/site/x86_64-linux
index 573a907..5b37211 100644
--- a/meta/site/x86_64-linux
+++ b/meta/site/x86_64-linux
@@ -104,6 +104,7 @@ nfsd_cv_func_statfs=${nfsd_cv_func_statfs=statfs2_bsize}
 nfsd_cv_bsd_signals=${nfsd_cv_bsd_signals=yes}
 
 #apr
+apr_cv_pthreads_cflags=${apr_cv_pthreads_cflags=-pthread}
 apr_cv_tcp_nodelay_with_cork=${apr_cv_tcp_nodelay_with_cork=yes}
 
 # lftp
-- 
2.7.1

Re: [PATCH v2] site: enable pthread support for x86_64 APR builds

[Richard Purdie]

On Mon, 2016-02-29 at 16:53 +0200, Ioan-Adrian Ratiu wrote:
> The apache2 package is missing key pieces of pthread support (notably
> pthread_kill) on x86_64 platforms. Fix this by setting cached
> variable
> apr_cv_pthreads_cflags=-pthread which will trickle down into apache2
> as
> well. powerpc32-linux currently sets this option.
> 
> Suggested-by: Jacob Champion <jacob.champion@ni.com>
> Signed-off-by: Ioan-Adrian Ratiu <adrian.ratiu@ni.com>
> ---
>  meta/site/x86_64-linux | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/meta/site/x86_64-linux b/meta/site/x86_64-linux
> index 573a907..5b37211 100644
> --- a/meta/site/x86_64-linux
> +++ b/meta/site/x86_64-linux
> @@ -104,6 +104,7 @@
> nfsd_cv_func_statfs=${nfsd_cv_func_statfs=statfs2_bsize}
>  nfsd_cv_bsd_signals=${nfsd_cv_bsd_signals=yes}
>  
>  #apr
> +apr_cv_pthreads_cflags=${apr_cv_pthreads_cflags=-pthread}
>  apr_cv_tcp_nodelay_with_cork=${apr_cv_tcp_nodelay_with_cork=yes}

Autobuilder doesn't look happy after this change:

https://autobuilder.yoctoproject.org/main/builders/build-appliance/buil
ds/662/steps/BuildImages_1/logs/stdio

This was the only change to apr in there so its looking like the most
likely suspect...

Cheers,

Richard

Re: [PATCH v2] site: enable pthread support for x86_64 APR builds

[Ioan-Adrian Ratiu]

On Mon, 29 Feb 2016 20:17:47 +0000
Richard Purdie <richard.purdie@linuxfoundation.org> wrote:

> On Mon, 2016-02-29 at 16:53 +0200, Ioan-Adrian Ratiu wrote:
> > The apache2 package is missing key pieces of pthread support (notably
> > pthread_kill) on x86_64 platforms. Fix this by setting cached
> > variable
> > apr_cv_pthreads_cflags=-pthread which will trickle down into apache2
> > as
> > well. powerpc32-linux currently sets this option.
> > 
> > Suggested-by: Jacob Champion <jacob.champion@ni.com>
> > Signed-off-by: Ioan-Adrian Ratiu <adrian.ratiu@ni.com>
> > ---
> >  meta/site/x86_64-linux | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/meta/site/x86_64-linux b/meta/site/x86_64-linux
> > index 573a907..5b37211 100644
> > --- a/meta/site/x86_64-linux
> > +++ b/meta/site/x86_64-linux
> > @@ -104,6 +104,7 @@
> > nfsd_cv_func_statfs=${nfsd_cv_func_statfs=statfs2_bsize}
> >  nfsd_cv_bsd_signals=${nfsd_cv_bsd_signals=yes}
> >  
> >  #apr
> > +apr_cv_pthreads_cflags=${apr_cv_pthreads_cflags=-pthread}
> >  apr_cv_tcp_nodelay_with_cork=${apr_cv_tcp_nodelay_with_cork=yes}  
> 
> Autobuilder doesn't look happy after this change:
> 
> https://autobuilder.yoctoproject.org/main/builders/build-appliance/buil
> ds/662/steps/BuildImages_1/logs/stdio
> 
> This was the only change to apr in there so its looking like the most
> likely suspect...

Yes, it definitely is, a line was removed in v2 after review which seems to trigger it.
I'll try to find a better solution.

> 
> Cheers,
> 
> Richard

Re: [PATCH v2] site: enable pthread support for x86_64 APR builds

[Khem Raj]

[-- Attachment #1: Type: text/plain, Size: 1701 bytes --]


> On Feb 29, 2016, at 12:17 PM, Richard Purdie <richard.purdie@linuxfoundation.org> wrote:
> 
> On Mon, 2016-02-29 at 16:53 +0200, Ioan-Adrian Ratiu wrote:
>> The apache2 package is missing key pieces of pthread support (notably
>> pthread_kill) on x86_64 platforms. Fix this by setting cached
>> variable
>> apr_cv_pthreads_cflags=-pthread which will trickle down into apache2
>> as
>> well. powerpc32-linux currently sets this option.
>> 
>> Suggested-by: Jacob Champion <jacob.champion@ni.com>
>> Signed-off-by: Ioan-Adrian Ratiu <adrian.ratiu@ni.com>
>> ---
>> meta/site/x86_64-linux | 1 +
>> 1 file changed, 1 insertion(+)
>> 
>> diff --git a/meta/site/x86_64-linux b/meta/site/x86_64-linux
>> index 573a907..5b37211 100644
>> --- a/meta/site/x86_64-linux
>> +++ b/meta/site/x86_64-linux
>> @@ -104,6 +104,7 @@
>> nfsd_cv_func_statfs=${nfsd_cv_func_statfs=statfs2_bsize}
>> nfsd_cv_bsd_signals=${nfsd_cv_bsd_signals=yes}
>> 
>> #apr
>> +apr_cv_pthreads_cflags=${apr_cv_pthreads_cflags=-pthread}
>> apr_cv_tcp_nodelay_with_cork=${apr_cv_tcp_nodelay_with_cork=yes}
> 
> Autobuilder doesn't look happy after this change:
> 
> https://autobuilder.yoctoproject.org/main/builders/build-appliance/buil
> ds/662/steps/BuildImages_1/logs/stdio
> 
> This was the only change to apr in there so its looking like the most
> likely suspect…


IMO caching config variables in site files should only be applied to
target packages.

> 
> Cheers,
> 
> Richard
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core


[-- Attachment #2: Message signed with OpenPGP using GPGMail --]
[-- Type: application/pgp-signature, Size: 211 bytes --]