Re: [PATCH] gcc: add TUNE_CCARGS for CFLAGS_FOR_TARGET of gcc-cross-canadian

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Tue, 2016-03-01 at 15:53 +0800, Zhou, Li wrote:
> Please refer to Peter Seebach's patch earlier:
> http://lists.openembedded.org/pipermail/openembedded-core/2016-Januar
> y/115472.html
> My patch should be based on that.
> I think the change is not only for canadian build. Thanks.
> 
> On 03/01/2016 02:12 PM, Khem Raj wrote:
> > On Mon, Feb 29, 2016 at 6:22 PM, Li Zhou <li.zhou@windriver.com>
> > wrote:
> > > Add TUNE_CCARGS for CFLAGS_FOR_TARGET of gcc-cross-canadian to
> > > solve
> > > below errors when compiling gcc-cross-canadian-powerpc64 within a
> > > debug
> > > build:
> > > 
> > > configure:3655: checking for suffix of object files
> > > configure:3677:  powerpc64-wrs-linux-gcc -
> > > -sysroot=......bitbake_build/
> > > tmp/sysroots/fsl-t2xxx -isystem=/usr/include --sysroot=....../
> > > bitbake_build/tmp/sysroots/fsl-t2xxx   -c -O0 -fno-omit-frame
> > > -pointer -g
> > > -pipe -g -Os  conftest.c >&5
> > > {standard input}: Assembler messages:
> > > {standard input}:23: Error: register save offset not a multiple
> > > of 8
> > > {standard input}:24: Error: register save offset not a multiple
> > > of 8
> > > 
> > > Signed-off-by: Li Zhou <li.zhou@windriver.com>
> > > ---
> > >   meta/recipes-devtools/gcc/gcc-cross-canadian.inc |    2 +-
> > >   1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/meta/recipes-devtools/gcc/gcc-cross-canadian.inc
> > > b/meta/recipes-devtools/gcc/gcc-cross-canadian.inc
> > > index ec1d281..04ae981 100644
> > > --- a/meta/recipes-devtools/gcc/gcc-cross-canadian.inc
> > > +++ b/meta/recipes-devtools/gcc/gcc-cross-canadian.inc
> > > @@ -51,7 +51,7 @@ do_configure () {
> > >          export CPPFLAGS_FOR_BUILD="${BUILD_CPPFLAGS}"
> > >          export CXXFLAGS_FOR_BUILD="${BUILD_CXXFLAGS}"
> > >          export LDFLAGS_FOR_BUILD="${BUILD_LDFLAGS}"
> > > -       export CFLAGS_FOR_TARGET="${TARGET_CFLAGS}"
> > > +       export CFLAGS_FOR_TARGET="${TARGET_CFLAGS}
> > > ${TUNE_CCARGS}"
> > Will this cause canadian builds to become too specific instead of
> > generic common arch

I agree with Khem, I think there are potential problems this
introduces. Did you try running the selftests for sstate sigs with this
change? I suspect it breaks :(

Cheers,

Richard