From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dan.rpsys.net (5751f4a1.skybroadband.com [87.81.244.161]) by mail.openembedded.org (Postfix) with ESMTP id 67CCC731EA for ; Tue, 1 Mar 2016 11:27:35 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by dan.rpsys.net (8.14.4/8.14.4/Debian-4.1ubuntu1) with ESMTP id u21BRZE6008518; Tue, 1 Mar 2016 11:27:35 GMT Received: from dan.rpsys.net ([127.0.0.1]) by localhost (dan.rpsys.net [127.0.0.1]) (amavisd-new, port 10024) with LMTP id nj7bwGmGMCe9; Tue, 1 Mar 2016 11:27:35 +0000 (GMT) Received: from hex ([192.168.3.34]) (authenticated bits=0) by dan.rpsys.net (8.14.4/8.14.4/Debian-4.1ubuntu1) with ESMTP id u21BRV83008515 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=NOT); Tue, 1 Mar 2016 11:27:33 GMT Message-ID: <1456831651.25131.1.camel@linuxfoundation.org> From: Richard Purdie To: "Zhou, Li" , Khem Raj Date: Tue, 01 Mar 2016 11:27:31 +0000 In-Reply-To: <56D54A81.8000704@windriver.com> References: <1456798957-22223-1-git-send-email-li.zhou@windriver.com> <56D54A81.8000704@windriver.com> X-Mailer: Evolution 3.16.5-1ubuntu3.1 Mime-Version: 1.0 Cc: Patches and discussions about the oe-core layer Subject: Re: [PATCH] gcc: add TUNE_CCARGS for CFLAGS_FOR_TARGET of gcc-cross-canadian X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Mar 2016 11:27:36 -0000 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit On Tue, 2016-03-01 at 15:53 +0800, Zhou, Li wrote: > Please refer to Peter Seebach's patch earlier: > http://lists.openembedded.org/pipermail/openembedded-core/2016-Januar > y/115472.html > My patch should be based on that. > I think the change is not only for canadian build. Thanks. > > On 03/01/2016 02:12 PM, Khem Raj wrote: > > On Mon, Feb 29, 2016 at 6:22 PM, Li Zhou > > wrote: > > > Add TUNE_CCARGS for CFLAGS_FOR_TARGET of gcc-cross-canadian to > > > solve > > > below errors when compiling gcc-cross-canadian-powerpc64 within a > > > debug > > > build: > > > > > > configure:3655: checking for suffix of object files > > > configure:3677: powerpc64-wrs-linux-gcc - > > > -sysroot=......bitbake_build/ > > > tmp/sysroots/fsl-t2xxx -isystem=/usr/include --sysroot=....../ > > > bitbake_build/tmp/sysroots/fsl-t2xxx -c -O0 -fno-omit-frame > > > -pointer -g > > > -pipe -g -Os conftest.c >&5 > > > {standard input}: Assembler messages: > > > {standard input}:23: Error: register save offset not a multiple > > > of 8 > > > {standard input}:24: Error: register save offset not a multiple > > > of 8 > > > > > > Signed-off-by: Li Zhou > > > --- > > > meta/recipes-devtools/gcc/gcc-cross-canadian.inc | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/meta/recipes-devtools/gcc/gcc-cross-canadian.inc > > > b/meta/recipes-devtools/gcc/gcc-cross-canadian.inc > > > index ec1d281..04ae981 100644 > > > --- a/meta/recipes-devtools/gcc/gcc-cross-canadian.inc > > > +++ b/meta/recipes-devtools/gcc/gcc-cross-canadian.inc > > > @@ -51,7 +51,7 @@ do_configure () { > > > export CPPFLAGS_FOR_BUILD="${BUILD_CPPFLAGS}" > > > export CXXFLAGS_FOR_BUILD="${BUILD_CXXFLAGS}" > > > export LDFLAGS_FOR_BUILD="${BUILD_LDFLAGS}" > > > - export CFLAGS_FOR_TARGET="${TARGET_CFLAGS}" > > > + export CFLAGS_FOR_TARGET="${TARGET_CFLAGS} > > > ${TUNE_CCARGS}" > > Will this cause canadian builds to become too specific instead of > > generic common arch I agree with Khem, I think there are potential problems this introduces. Did you try running the selftests for sstate sigs with this change? I suspect it breaks :( Cheers, Richard