Openembedded Core Discussions
 help / color / mirror / Atom feed
* [PATCH] ext-sdk-prepare: Catch setscene tasks which should have run but didn't
@ 2016-03-04 16:22 Richard Purdie
  0 siblings, 0 replies; only message in thread
From: Richard Purdie @ 2016-03-04 16:22 UTC (permalink / raw)
  To: openembedded-core

When installing the eSDK, if setscene task fail for some reason, the tests 
would ignore this. This is bad since we assume they're working.

This adds some sanity test code which detects if setscene tasks are 
needing to run and errors if there are any.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>

diff --git a/meta/files/ext-sdk-prepare.py b/meta/files/ext-sdk-prepare.py
index 143e0fe..c99e34f 100644
--- a/meta/files/ext-sdk-prepare.py
+++ b/meta/files/ext-sdk-prepare.py
@@ -72,12 +72,14 @@ def main():
                 else:
                     line = line.split('Running', 1)[-1]
                     unexpected.append(line.rstrip())
+            elif 'Running setscene' in line:
+                unexpected.append(line.rstrip())
     except subprocess.CalledProcessError as e:
         print('ERROR: Failed to execute dry-run:\n%s' % e.output)
         return 1
 
     if unexpected:
-        print('ERROR: Unexpected tasks left over to be executed:')
+        print('ERROR: Unexpected tasks or setscene left over to be executed:')
         for line in unexpected:
             print('  ' + line)
         return 1




^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2016-03-04 16:22 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-04 16:22 [PATCH] ext-sdk-prepare: Catch setscene tasks which should have run but didn't Richard Purdie

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox