Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Jonathan Liu <net147@gmail.com>
Cc: "openembedded-core@lists.openembedded.org"
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] gdb-cross-canadian: fix enabling of Python support
Date: Fri, 25 Mar 2016 09:26:51 +0000	[thread overview]
Message-ID: <1458898011.3073.48.camel@linuxfoundation.org> (raw)
In-Reply-To: <CANwerB1wqVPz4CgP24AuUOkKkxnwakaQPYtQmgWG_Lb10z1H_w@mail.gmail.com>

On Fri, 2016-03-25 at 19:58 +1100, Jonathan Liu wrote:
> Hi Richard,
> 
> On 25 March 2016 at 19:54, Richard Purdie
> <richard.purdie@linuxfoundation.org> wrote:
> > On Fri, 2016-03-25 at 17:25 +1100, Jonathan Liu wrote:
> > > Python support was not being enabled because of a conflicting
> > > --without-python configure argument in OE_EXTRACONF.
> > > 
> > > Signed-off-by: Jonathan Liu <net147@gmail.com>
> > > ---
> > >  meta/recipes-devtools/gdb/gdb-cross-canadian.inc | 1 +
> > >  1 file changed, 1 insertion(+)
> > > 
> > > diff --git a/meta/recipes-devtools/gdb/gdb-cross-canadian.inc
> > > b/meta/recipes-devtools/gdb/gdb-cross-canadian.inc
> > > index ae97759..6fd3e3e 100644
> > > --- a/meta/recipes-devtools/gdb/gdb-cross-canadian.inc
> > > +++ b/meta/recipes-devtools/gdb/gdb-cross-canadian.inc
> > > @@ -13,6 +13,7 @@ RDEPENDS_${PN} += "nativesdk-python-core
> > > nativesdk
> > > -python-lang nativesdk-python-
> > > 
> > >  GDBPROPREFIX = "--program-prefix='${TARGET_PREFIX}'"
> > > 
> > > +EXTRA_OECONF_remove = "--without-python"
> > >  EXTRA_OECONF_append = " --with-python=${WORKDIR}/python"
> > 
> > Would a PACKAGECONFIG += "python" have the same effect?
> > 
> > Cheers,
> > 
> > Richard
> > 
> > 
> > 
> 
> No, it wouldn't. It would depend on python and python-codecs then
> fail
> when building SDK.

Ok, I still don't think the above is the right fix though as it still
leaves things fragile, if for example I try and enable python for gdb
by default on target.

I think we may need to do something like:

-PACKAGECONFIG[python] = "--with-python=${WORKDIR}/python,--without
-python,python,python python-codecs"
+ PACKAGECONFIG[python] = "--with-python=${WORKDIR}/python,--without
-python,python,${GDBPYTHON_RDEPENDS}"

+GDBPYTHON_RDEPENDS = "python python-codecs"

and then set:

GDBPYTHON_RDEPENDS = ""
PACKAGECONFIG += "python"

in the cross recipes.

Would that work?

Cheers,

Richard


  reply	other threads:[~2016-03-25  9:26 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-25  6:25 [PATCH] gdb-cross-canadian: fix enabling of Python support Jonathan Liu
2016-03-25  8:54 ` Richard Purdie
2016-03-25  8:58   ` Jonathan Liu
2016-03-25  9:26     ` Richard Purdie [this message]
2016-03-25 10:29       ` Jonathan Liu
2016-03-25 10:34         ` Richard Purdie
2016-03-25 11:35 ` Jonathan Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1458898011.3073.48.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=net147@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox