Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Peter Kjellerstedt <peter.kjellerstedt@axis.com>,
	Otavio Salvador <otavio.salvador@ossystems.com.br>
Cc: "OE Core \(openembedded-core@lists.openembedded.org\)"
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCHv2 1/1] Revert "useradd.bbclass: remove user/group created by the package in clean* task"
Date: Wed, 13 Apr 2016 12:05:15 +0100	[thread overview]
Message-ID: <1460545515.9308.85.camel@linuxfoundation.org> (raw)
In-Reply-To: <4550e71bd1f24135a2f6978294e25f94@XBOX02.axis.com>

I am pretty frustrated with this thread. The reasons are perhaps not
immediately obvious though.

The issue is that there are only a limited number of people who
actually dive in and try and fix some of the underlying "core
architecture" bugs. There is what I believe to be a pretty good patch
here which does fix real world issues which have been reported into the
bugzilla (its related to at least two bug reports). As such it has been
seen as a bugfix. Its now clear it does have some side effects which
weren't envisaged, some causing issues for a small number of meta-oe
recipes, the others breaking a companies internal code.

Otavio wants it deferred to 2.2, Peter wants it abandoned entirely.

If I revert this, Peter is then happy and has zero incentive to do
anything further. The pressure is still on the reopened bugs to try and
fix this somehow and falls back to the usual suspects. There is a real
world usability problem there.

In a single isolated case, fine, we'd figure a way through this. I
think I'm so frustrated as we see this all the time. Making a change to
the core architecture is hard and gets ever harder, then we wonder why
we don't have contributors. Part of this is having so many different
workflows and corner cases.

I have pushed very hard to have more test cases, then its easier to
determine if a patch causes regressions. Again though, few people are
contributing to them outside the usual suspects.

I'm therefore starting to think the correct answer to this thread is
simply this:

The patch doesn't break any of the current regression tests. If you
have use cases like this you care about, you really should make sure we
have test coverage for them, else you run the risk of exactly the
problem we have here.

I haven't honestly decided what to do but this latter conclusion is
very tempting from where I'm sitting...

Cheers,

Richard



  reply	other threads:[~2016-04-13 11:05 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-12 13:18 [PATCHv2 0/1] Revert cleaning of users/groups Peter Kjellerstedt
2016-04-12 13:18 ` [PATCHv2 1/1] Revert "useradd.bbclass: remove user/group created by the package in clean* task" Peter Kjellerstedt
2016-04-12 13:34   ` Otavio Salvador
2016-04-12 14:54   ` Richard Purdie
2016-04-12 16:35     ` Otavio Salvador
2016-04-12 17:28       ` Peter Kjellerstedt
2016-04-13 11:05         ` Richard Purdie [this message]
2016-04-13 15:14           ` Peter Kjellerstedt
2016-04-13 16:04             ` Maxin B. John
2016-04-13 16:29             ` Richard Purdie
2016-04-14 10:40               ` Richard Purdie
2016-04-14 11:46                 ` Peter Kjellerstedt
2016-04-14 11:50                   ` Richard Purdie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1460545515.9308.85.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=otavio.salvador@ossystems.com.br \
    --cc=peter.kjellerstedt@axis.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox