From: "Randle, William C" <william.c.randle@intel.com>
To: "denis@denix.org" <denis@denix.org>,
"danismostlikely@gmail.com" <danismostlikely@gmail.com>
Cc: "openembedded-core@lists.openembedded.org"
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] package.bbclass: handle links in sorted order
Date: Wed, 13 Apr 2016 17:40:19 +0000 [thread overview]
Message-ID: <1460569219.21923.2.camel@intel.com> (raw)
In-Reply-To: <CACS+7ZTTJOohmfe_iY3Y5Hc_FpLVh8Jvbpx9tdBAbifS4COWaQ@mail.gmail.com>
On Wed, 2016-04-13 at 11:30 -0600, Dan McGregor wrote:
On 12 April 2016 at 10:51, Denys Dmytriyenko <denis@denix.org<mailto:denis@denix.org>> wrote:
On Tue, Apr 12, 2016 at 08:22:21AM -0700, Bill Randle wrote:
When processing links, the directories are processed in unsorted order
which can result in cases like /var/lock -> /run/lock handled before
/var/run -> /run throwing an error for /var/run because /run already exists.
Change the link processing to ensure links are processed in sorted order of
the destination.
Seems to resolve the issue for me.
For me it introduces a new issue. I use two perm files, the OE default
one, and one that changes two links to real directories. The new
packaging code complains that a link target exists as a directory,
even though a subsequent rule sets it up as a directory.
I think during parsing it should remove links as it finds directories
with the same path, and remove directories with the same path in the
order it sees them, that way when it does the in order processing it
uses the last definition in the permissions table.
Dan, can you provide an example permissions file that illustrates this? Preferably via the Bugzilla entry, or if not convenient, then here?
[YOCTO #9430]
Signed-off-by: Bill Randle <william.c.randle@intel.com<mailto:william.c.randle@intel.com>>
Reported-by: Denys Dmytriyenko <denys@ti.com<mailto:denys@ti.com>>
Tested-by: Denys Dmytriyenko <denys@ti.com<mailto:denys@ti.com>>
next prev parent reply other threads:[~2016-04-13 17:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-12 15:22 [PATCH] package.bbclass: handle links in sorted order Bill Randle
2016-04-12 16:51 ` Denys Dmytriyenko
2016-04-13 17:30 ` Dan McGregor
2016-04-13 17:40 ` Randle, William C [this message]
2016-04-13 18:54 ` Dan McGregor
2016-04-13 22:17 ` [PATCH] package.bbclass: improve permission handling Dan McGregor
2016-04-14 0:14 ` Randle, William C
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1460569219.21923.2.camel@intel.com \
--to=william.c.randle@intel.com \
--cc=danismostlikely@gmail.com \
--cc=denis@denix.org \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox