Re: [PATCH] Allow different filesystems to be used for VM images.

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Fri, 2016-04-29 at 06:50 -0400, Ian Geiser wrote:
>  ---- On Fri, 29 Apr 2016 04:19:00 -0400 Richard Purdie <
> richard.purdie@linuxfoundation.org> wrote ---- 
>  > On Thu, 2016-04-28 at 15:21 -0400, Ian Reinhart Geiser wrote: 
>  > > This allows for things like btrfs to be used vs just ext4. 
>  > > The default value of ext4 is kept so there is no functional 
>  > > change unless ROOTFS_TYPE is set in the inherting recipe. 
>  > >  
>  > > Signed-off-by: Ian Reinhart Geiser <geiseri@geekcentral.pub> 
>  > > --- 
>  > >  meta/classes/image-vm.bbclass | 13 +++++++------ 
>  > >  1 file changed, 7 insertions(+), 6 deletions(-) 
>  >  
>  >  
>  > This seems reasonable but could I ask you to use a variable name
> with 
>  > "VM" in the name please? 
>  >  
>  > I appreciate some of the existing ones don't do this but moving
> forward 
>  > we need to try and better namespace some of these class specific 
>  > variables and this seems like a good place to start. 
>  >  
>  > VM_ROOTFS_TYPE would be better for example (or VMIMG_ROOTFS_TYPE).
>  >  
> The other ones have foo_VM in the name.  Would ROOTFS_TYPE_VM be
> acceptable?

I'd really prefer to try and use a prefix since otherwise its harder to
know this is from the VM class rather than the rootfs classes which
already heavily use ROOTFS_*...

Cheers,

Richard