From: Christopher Larson <kergoth@gmail.com>
To: openembedded-core@lists.openembedded.org
Cc: Christopher Larson <chris_larson@mentor.com>
Subject: [master][PATCH] gcc-cross{, -canadian}: remove --with-linker-hash-style
Date: Mon, 2 May 2016 13:09:25 -0700 [thread overview]
Message-ID: <1462219765-18957-1-git-send-email-kergoth@gmail.com> (raw)
From: Christopher Larson <chris_larson@mentor.com>
We explicitly set the hash style to gnu in our LDFLAGS. Setting the default to
this in the toolchain, while convenient, actually hides bugs, as a failure to
obey LDFLAGS isn't noticed. By removing this, it's not dissimilar to how we
poison the sysroot -- rather than relying on the default, notice right away if
somoeone isn't obeying the needed flags.
This will result in a failure to obey LDFLAGS causing a GNU_HASH QA failure,
which is what's often seen with external toolchains. This brings us all on the
same page, and makes sure a failure to obey LDFLAGS is seen early.
Signed-off-by: Christopher Larson <chris_larson@mentor.com>
---
meta/recipes-devtools/gcc/gcc-4.9.inc | 1 -
meta/recipes-devtools/gcc/gcc-5.3.inc | 1 -
2 files changed, 2 deletions(-)
diff --git a/meta/recipes-devtools/gcc/gcc-4.9.inc b/meta/recipes-devtools/gcc/gcc-4.9.inc
index 7e03f31..c187918 100644
--- a/meta/recipes-devtools/gcc/gcc-4.9.inc
+++ b/meta/recipes-devtools/gcc/gcc-4.9.inc
@@ -111,7 +111,6 @@ EXTRA_OECONF_BASE = "\
--disable-bootstrap \
--disable-libmudflap \
--with-system-zlib \
- --with-linker-hash-style=${LINKER_HASH_STYLE} \
--enable-linker-build-id \
--with-ppl=no \
--with-cloog=no \
diff --git a/meta/recipes-devtools/gcc/gcc-5.3.inc b/meta/recipes-devtools/gcc/gcc-5.3.inc
index 9808be1..f2eda18 100644
--- a/meta/recipes-devtools/gcc/gcc-5.3.inc
+++ b/meta/recipes-devtools/gcc/gcc-5.3.inc
@@ -112,7 +112,6 @@ EXTRA_OECONF_BASE = "\
--disable-bootstrap \
--disable-libmudflap \
--with-system-zlib \
- --with-linker-hash-style=${LINKER_HASH_STYLE} \
--enable-linker-build-id \
--with-ppl=no \
--with-cloog=no \
--
2.8.0
next reply other threads:[~2016-05-02 20:09 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-02 20:09 Christopher Larson [this message]
2016-05-02 20:34 ` [master][PATCH] gcc-cross{, -canadian}: remove --with-linker-hash-style Khem Raj
2016-05-02 20:37 ` Christopher Larson
2016-05-02 21:37 ` Khem Raj
2016-05-03 2:53 ` Christopher Larson
2016-05-03 3:01 ` Khem Raj
2016-05-03 3:05 ` Christopher Larson
2016-05-03 8:09 ` Martin Jansa
2016-05-03 9:11 ` Anders Darander
2016-05-03 16:07 ` Christopher Larson
2016-05-03 18:13 ` Denys Dmytriyenko
2016-05-04 14:01 ` Burton, Ross
2016-05-04 19:11 ` Christopher Larson
2016-05-09 16:35 ` Bystricky, Juro
2016-05-09 16:39 ` Christopher Larson
2016-05-09 22:16 ` Richard Purdie
2016-05-09 22:34 ` Christopher Larson
2016-05-09 22:41 ` Christopher Larson
2016-05-09 22:54 ` Richard Purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1462219765-18957-1-git-send-email-kergoth@gmail.com \
--to=kergoth@gmail.com \
--cc=chris_larson@mentor.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox