From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Paul Eggleton <paul.eggleton@linux.intel.com>,
openembedded-core@lists.openembedded.org,
Robert Yang <liezhi.yang@windriver.com>
Subject: Re: [PATCH v2 1/2] classes/insane: do not force LIC_FILES_CHKSUM unless SRC_URI is set
Date: Wed, 11 May 2016 10:36:24 +0100 [thread overview]
Message-ID: <1462959384.21831.206.camel@linuxfoundation.org> (raw)
In-Reply-To: <f072033b140806b67ff2b098d6aa3d3a7e85a7b5.1462832624.git.paul.eggleton@linux.intel.com>
On Tue, 2016-05-10 at 10:25 +1200, Paul Eggleton wrote:
> Recipes such as images and packagegroups don't actually fetch or
> build
> any source, so there's really no point having LIC_FILES_CHKSUM set.
> Forcing users to set it (as we have done for images inheriting
> image.bbclass) just makes things more difficult for the user for no
> discernable benefit. The easiest way to adjust this check is simply
> to
> skip it if SRC_URI is not set since this is a pretty good indicator
> that
> no source is being pulled in.
>
> Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
> ---
> meta/classes/insane.bbclass | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
One reason -next has sat as long as I couldn't figure out who broke the
lic-checksums sanity test. The answer is Robert's patch did, then this
one did as well, making it hard to blame any one person.
I've merged a fix into master along with the other patches.
Cheers,
Richard
next prev parent reply other threads:[~2016-05-11 9:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-09 22:25 [PATCH v2 0/2] More reasonable LIC_FILES_CHKSUM enforcement Paul Eggleton
2016-05-09 22:25 ` [PATCH v2 1/2] classes/insane: do not force LIC_FILES_CHKSUM unless SRC_URI is set Paul Eggleton
2016-05-09 23:18 ` Mark Hatle
2016-05-09 23:29 ` Khem Raj
2016-05-11 9:36 ` Richard Purdie [this message]
2016-05-09 22:25 ` [PATCH v2 2/2] Drop unneeded LIC_FILES_CHKSUM values Paul Eggleton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1462959384.21831.206.camel@linuxfoundation.org \
--to=richard.purdie@linuxfoundation.org \
--cc=liezhi.yang@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=paul.eggleton@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox