From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Ed Bartosh <ed.bartosh@linux.intel.com>,
openembedded-core@lists.openembedded.org
Subject: Re: [RFC][PATCH 0/7] image creation improvements
Date: Fri, 13 May 2016 18:06:02 +0100 [thread overview]
Message-ID: <1463159162.9746.117.camel@linuxfoundation.org> (raw)
In-Reply-To: <cover.1462545440.git.ed.bartosh@linux.intel.com>
On Fri, 2016-05-06 at 17:58 +0300, Ed Bartosh wrote:
> Hi,
>
> This patchset contains various improvements for the image creation
> functionality
> made by Patchick Ohly during his work on bug #9076:
> - added support for zip compression
> - fixed dependency calculation for conversion chaining
> - converted vmdk/vdi/qcow2 image types into conversion commands
> - renamed COMPRESSION variables to CONVERSION as the term
> "compression"
> is no longer accurate
> - prioritized specialized image creation methods over using
> conversion chaining
>
> The changes look reasonable to me. However, it would be good to hear
> other
> people opinions as some changes are quite complex.
Ross made some changes to the imagetypes code and I suspect this series
won't apply on top of them. I also don't like moving that dependency
code to image.bbclass, even if its the only caller. The idea is to keep
the "image types" code into its own class.
I'll queue the zip piece but the rest probably needs to be rebased...
Cheers,
Richard
prev parent reply other threads:[~2016-05-13 17:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-06 14:58 [RFC][PATCH 0/7] image creation improvements Ed Bartosh
2016-05-06 14:58 ` [RFC][PATCH 1/7] image_types: add support for zip compression Ed Bartosh
2016-05-06 14:58 ` [RFC][PATCH 2/7] image.bbclass: support duplicate compression types Ed Bartosh
2016-05-06 14:58 ` [RFC][PATCH 3/7] image.bbclass: fix dependency calculation when using conversion chaining Ed Bartosh
2016-05-06 14:58 ` [RFC][PATCH 4/7] image.bbclass: additional output in create_symlinks Ed Bartosh
2016-05-06 14:58 ` [RFC][PATCH 5/7] image creation: support converting masked types Ed Bartosh
2016-05-06 14:58 ` [RFC][PATCH 6/7] image.bbclass: rename COMPRESS(ION) to CONVERSION Ed Bartosh
2016-05-06 14:58 ` [RFC][PATCH 7/7] image.bbclass: prefer specialized image creation methods over chaining Ed Bartosh
2016-05-13 17:06 ` Richard Purdie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1463159162.9746.117.camel@linuxfoundation.org \
--to=richard.purdie@linuxfoundation.org \
--cc=ed.bartosh@linux.intel.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox