From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Ed Bartosh <ed.bartosh@linux.intel.com>,
openembedded-core@lists.openembedded.org
Subject: Re: [PATCH v3 4/6] bmap-tools: generate standalone script
Date: Fri, 13 May 2016 18:13:53 +0100 [thread overview]
Message-ID: <1463159633.9746.121.camel@linuxfoundation.org> (raw)
In-Reply-To: <9d32811fe04ce49bdc20891453d37819447d7f88.1462191317.git.ed.bartosh@linux.intel.com>
On Mon, 2016-05-02 at 15:22 +0300, Ed Bartosh wrote:
> Generated standalone bmaptool script that is more convenient
> to use than native script. It can be run straight from
> its location ./tmp/deploy/tools/bmaptool. The script doesn't
> depend on anything except Python.
>
> Signed-off-by: Ed Bartosh <ed.bartosh@linux.intel.com>
> ---
> meta/recipes-support/bmap-tools/bmap-tools_3.2.bb | 20
> +++++++++++++++++++-
> 1 file changed, 19 insertions(+), 1 deletion(-)
>
> diff --git a/meta/recipes-support/bmap-tools/bmap-tools_3.2.bb
> b/meta/recipes-support/bmap-tools/bmap-tools_3.2.bb
> index e10f5fd..0f95788 100644
> --- a/meta/recipes-support/bmap-tools/bmap-tools_3.2.bb
> +++ b/meta/recipes-support/bmap-tools/bmap-tools_3.2.bb
> @@ -15,10 +15,28 @@ SRC_URI[sha256sum] =
> "cc6c7f7dc0a37e2a32deb127308e24e6c4b80bfb54f3803c308efab02b
>
> RDEPENDS_${PN} = "python-core python-compression"
>
> -inherit setuptools
> +inherit setuptools deploy
>
> BBCLASSEXTEND = "native"
>
> do_install_append_class-native() {
> sed -i -e 's|^#!.*/usr/bin/env python|#! /usr/bin/env
> nativepython|' ${D}${bindir}/bmaptool
> }
> +
> +do_deploy[sstate-outputdirs] = "${DEPLOY_DIR_TOOLS}"
> +do_deploy[stamp-extra-info] = ""
> +do_deploy_class-native() {
> + cp bmaptool __main__.py
> + python -m zipfile -c bmaptool.zip bmaptools __main__.py
> + echo '#!/usr/bin/env python' | cat - bmaptool.zip > bmaptool
> -standalone
> + install -d ${DEPLOYDIR}
> + install -m 0755 bmaptool-standalone ${DEPLOYDIR}/bmaptool-${PV}
> + rm -f ${DEPLOYDIR}/bmaptool
> + ln -sf ./bmaptool-${PV} ${DEPLOYDIR}/bmaptool
> +}
> +
> +do_deploy() {
> + :
> +}
> +
> +addtask deploy before do_package after do_install
I'm not sure if we want to do this in the first place. Regardless, the
addtask here is incorrect too.
Cheers,
Richard
next prev parent reply other threads:[~2016-05-13 17:14 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-02 12:22 [PATCH v3 0/6] bmaptool support Ed Bartosh
2016-05-02 12:22 ` [PATCH v3 1/6] bmap-tools: initial commit, version 3.2 Ed Bartosh
2016-05-02 12:22 ` [PATCH v3 2/6] image types: add bmap generation option Ed Bartosh
2016-05-02 12:22 ` [PATCH v3 3/6] selftest: add bmap test Ed Bartosh
2016-05-02 12:22 ` [PATCH v3 4/6] bmap-tools: generate standalone script Ed Bartosh
2016-05-03 19:31 ` Christopher Larson
2016-05-03 19:33 ` Christopher Larson
2016-05-04 7:01 ` Ed Bartosh
2016-05-04 18:55 ` Christopher Larson
2016-05-19 14:19 ` Alexander Kanevskiy
2016-05-19 14:54 ` Christopher Larson
2016-05-19 21:50 ` Alexander Kanevskiy
2016-05-19 21:53 ` Christopher Larson
2016-05-13 17:13 ` Richard Purdie [this message]
2016-05-18 12:34 ` [wic][PATCH 1/4] wic: add bmaptool to the list of utilities Ed Bartosh
2016-05-18 12:34 ` [wic][PATCH 2/4] wic: implement --bmap option Ed Bartosh
2016-05-18 12:34 ` [wic][PATCH 3/4] wic: add help for --bmap commandline option Ed Bartosh
2016-05-18 12:34 ` [wic][PATCH 4/4] oe-selftest: wic: add test_bmap test case Ed Bartosh
2016-05-02 12:22 ` [PATCH v3 5/6] wic: implement --bmap option Ed Bartosh
2016-05-02 12:22 ` [PATCH v3 6/6] oe-selftest: wic: add test_bmap test case Ed Bartosh
2016-05-03 20:22 ` [PATCH v3 0/6] bmaptool support Christopher Larson
2016-05-04 6:59 ` Ed Bartosh
2016-05-13 17:11 ` Richard Purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1463159633.9746.121.camel@linuxfoundation.org \
--to=richard.purdie@linuxfoundation.org \
--cc=ed.bartosh@linux.intel.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox