Re: [PATCH] smartpm: Don't ignore error if RPM transaction fails without problems

["Klauer, Daniel" <Daniel.Klauer@gin.de>]

Hello,

> You also need to add another check just before raising the error, or you
> would end up getting an "unknown error" raised there.
> I basically replaced:
> -        if (probs is not None) and (not retry):
> +       if (probs is not None) and ((len(probs) != 0) or not
> sysconf.has("attempt-install", soft=True)) and (not retry):

Hmm, it sounds like the attempt mode wants to ignore installation failures
(empty problems list) like before the patch, which makes sense to me. Afterall,
attempt mode wants to try installation and ignore failures. So it seems good to
fix this regression too.

However, I wonder why it never ignored a non-empty problems list, which would
also trigger an error. Maybe that case just never happens in practice, because
it's always just file conflicts. Those trigger a retry, which prevents the error
from being raised.

> BUT reflecting on the whole scheme, I'm wondering how it will work in case
> of file found conflict, since the problem package gets removed from the
> list, but the list is committed again, with most packages already
> installed...
> I therefore wonder that there could be the same error that I got in the end,
> i.e failing with package already installed - which should not fail for
> attempt only.

Indeed, I'm curious about that too...

If you could put together the patch, that would be great and fine with me.

Thanks,
Daniel